New rule: no-alias-methods#164
Merged
SimenB merged 5 commits intojest-community:masterfrom Sep 30, 2018
garyking:no-alias-methods
Merged
New rule: no-alias-methods#164SimenB merged 5 commits intojest-community:masterfrom garyking:no-alias-methods
SimenB merged 5 commits intojest-community:masterfrom
garyking:no-alias-methods
Conversation
SimenB
approved these changes
Sep 30, 2018
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
I like it, thanks!
Thoughts on allowing people to whitelist matchers they do want to keep?
Member
|
We can follow up with that later if people want it |
Member
|
🎉 This PR is included in version 21.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule ensures that only the canonical method name from the Jest docs are used for methods, rather than their alias forms. This ensures consistency in codebases, and makes it easier to search for all occurrences of a method.