fix(no-alias-methods): support .not, .resolves & .rejects (#210)

Author: noahbenham

rules/__tests__/no-alias-methods.test.js

@@ -153,5 +153,41 @@ ruleTester.run('no-alias-methods', rule, {
       ],
       output: 'expect(a).toThrow()',
     },
+    {
+      code: 'expect(a).resolves.toThrowError()',
+      errors: [
+        {
+          message:
+            'Replace toThrowError() with its canonical name of toThrow()',
+          column: 20,
+          line: 1,
+        },
+      ],
+      output: 'expect(a).resolves.toThrow()',
+    },
+    {
+      code: 'expect(a).rejects.toThrowError()',
+      errors: [
+        {
+          message:
+            'Replace toThrowError() with its canonical name of toThrow()',
+          column: 19,
+          line: 1,
+        },
+      ],
+      output: 'expect(a).rejects.toThrow()',
+    },
+    {
+      code: 'expect(a).not.toThrowError()',
+      errors: [
+        {
+          message:
+            'Replace toThrowError() with its canonical name of toThrow()',
+          column: 15,
+          line: 1,
+        },
+      ],
+      output: 'expect(a).not.toThrow()',
+    },
   ],
 });

rules/no-alias-methods.js

@@ -32,9 +32,19 @@ module.exports = {
           return;
         }
 
-        // Check if the method used matches any of ours.
-        const propertyName = method(node) && method(node).name;
-        const methodItem = methodNames.find(item => item[1] === propertyName);
+        let targetNode = method(node);
+        if (
+          targetNode.name === 'resolves' ||
+          targetNode.name === 'rejects' ||
+          targetNode.name === 'not'
+        ) {
+          targetNode = method(node.parent);
+        }
+
+        // Check if the method used matches any of ours
+        const methodItem = methodNames.find(
+          item => item[1] === targetNode.name
+        );
 
         if (methodItem) {
           context.report({
@@ -43,9 +53,9 @@ module.exports = {
               replace: methodItem[1],
               canonical: methodItem[0],
             },
-            node: method(node),
+            node: targetNode,
             fix(fixer) {
-              return [fixer.replaceText(method(node), methodItem[0])];
+              return [fixer.replaceText(targetNode, methodItem[0])];
             },
           });
         }