From ebc10c6d7d836a5e3abaa77ac5f1e81b15f9c3d0 Mon Sep 17 00:00:00 2001 From: Peter Goldstein Date: Thu, 10 Mar 2022 09:38:41 -0800 Subject: [PATCH 1/2] Fix truncation issue in CI configuration entries Zero terminated float values in GitHub Actions CI configurations are truncated, leading to unexpected behavior. In this instance this results loading an unexpected Ruby or ActiveModel version for several CI matrix entries. Specifically, the unquoted '3.0' is interpreted as '3', and the latest Ruby 3 version - at this time of writing 3.1.1 - is loaded. To ensure that a 3.0.x version is loaded, we need to add quotes. In the ActiveModel case, use of an unquoted '6.0' is interpreted as '6' and ActiveModel 6.1.4.6 is loaded at this time. To ensure a 6.0.x version is loaded, we need to add quotes. The unquoted '7.0' would have similar problems if and when a Rails 7.1.x is released.. --- .github/workflows/main.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e05d5292..e4e45f70 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -19,32 +19,32 @@ jobs: - 2.5 - 2.6 - 2.7 - - 3.0 + - '3.0' - 3.1 - jruby active_model: - 4.2 - 5.2 - - 6.0 + - '6.0' - 6.1 - - 7.0 + - '7.0' exclude: - ruby: 2.5 - active_model: 7.0 + active_model: '7.0' - ruby: 2.6 - active_model: 7.0 + active_model: '7.0' - ruby: 2.7 active_model: 4.2 - - ruby: 3.0 + - ruby: '3.0' active_model: 4.2 - - ruby: 3.0 + - ruby: '3.0' active_model: 5.2 - ruby: 3.1 active_model: 4.2 - ruby: 3.1 active_model: 5.2 - ruby: jruby - active_model: 7.0 + active_model: '7.0' env: ACTIVE_MODEL_VERSION: "~> ${{ matrix.active_model }}.0" From 398c86f74f35f5355e342e6b4a02da8a7542fdf7 Mon Sep 17 00:00:00 2001 From: Peter Goldstein Date: Fri, 11 Mar 2022 16:54:26 -0800 Subject: [PATCH 2/2] Quote all numerical values --- .github/workflows/main.yml | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e4e45f70..77cf6669 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -16,33 +16,33 @@ jobs: strategy: matrix: ruby: - - 2.5 - - 2.6 - - 2.7 + - '2.5' + - '2.6' + - '2.7' - '3.0' - - 3.1 + - '3.1' - jruby active_model: - - 4.2 - - 5.2 + - '4.2' + - '5.2' - '6.0' - - 6.1 + - '6.1' - '7.0' exclude: - - ruby: 2.5 + - ruby: '2.5' active_model: '7.0' - - ruby: 2.6 + - ruby: '2.6' active_model: '7.0' - - ruby: 2.7 - active_model: 4.2 + - ruby: '2.7' + active_model: '4.2' - ruby: '3.0' - active_model: 4.2 + active_model: '4.2' - ruby: '3.0' - active_model: 5.2 - - ruby: 3.1 - active_model: 4.2 - - ruby: 3.1 - active_model: 5.2 + active_model: '5.2' + - ruby: '3.1' + active_model: '4.2' + - ruby: '3.1' + active_model: '5.2' - ruby: jruby active_model: '7.0'