Merge pull request #115 from bmocm/node10

jeremycx · web-flow · commit 15f7535775f1 · 2019-01-02T11:29:25.000-05:00
Node.js v10 support.
diff --git a/LDAPCookie.cc b/LDAPCookie.cc
@@ -35,7 +35,8 @@ v8::Local<v8::Object> LDAPCookie::NewInstance() {
   const unsigned argc = 1;
   v8::Local<v8::Value> argv[argc] = { Nan::Undefined() };
   v8::Local<v8::Function> cons = Nan::New<v8::Function>(constructor);
-  v8::Local<v8::Object> instance = cons->NewInstance(argc, argv);
+  v8::Local<v8::Object> instance = Nan::NewInstance(cons, argc, argv)
+    .ToLocalChecked();
 
   return scope.Escape(instance);
 }
diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
   "dependencies": {
     "bindings": "^1.2.1",
     "lodash": "^3.10.1",
-    "nan": "^2.0.5",
+    "nan": "^2.12.1",
     "node-gyp": ""
   },
   "engines": {

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,8 @@ v8::Local<v8::Object> LDAPCookie::NewInstance() {`
`35`	`35`	`const unsigned argc = 1;`
`36`	`36`	`v8::Local<v8::Value> argv[argc] = { Nan::Undefined() };`
`37`	`37`	`v8::Local<v8::Function> cons = Nan::New<v8::Function>(constructor);`
`38`		`- v8::Local<v8::Object> instance = cons->NewInstance(argc, argv);`
	`38`	`+ v8::Local<v8::Object> instance = Nan::NewInstance(cons, argc, argv)`
	`39`	`+ .ToLocalChecked();`
`39`	`40`
`40`	`41`	`return scope.Escape(instance);`
`41`	`42`	`}`