-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[JENKINS-70895] skip isSecureContext check in automated tests
#7784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarkEWaite
merged 1 commit into
jenkinsci:master
from
MarkEWaite:guard-isSecureCheckout-from-htmlUnit
Apr 1, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't
be the simpler change (found in @jtnord's Jira comment)?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see documentation on MDN for the global
isSecureContext. In the MDN documentation forwindow, thewindow.isSecureContextheading links to the documentation of the global property. I assumed that means the MDN recommends use of the global rather than usingwindow.isSecureContext.There is not a
window.isSecureContextpage on MDN (404 from https://developer.mozilla.org/en-US/docs/Web/API/Window/isSecureContext ), though there was at one point as indicated by a link from a stackoverflow article.I also believe that I read a recommendation on some location that the global
isSecureContextwas preferred. However, I can't find that reference now.I also prefer the added check of
window.isRunAsTestbecause it makes it clear that this workaround can be removed when we update to an HTMLUnit version that recognizes the globalisSecureContext. See the response from the maintainer of HTMLUnit in:If changing the implementation to the
window.secureContextinstead of!window.isRunAsTest && isSecureConextwill allow this to be merged, then I am happy to change it to that form.The W3C Candidate Recommendation Draft, 18 September 2021 spec for secure context says in section 2.2.2:
Since the spec says that the boolean is defined on window or worker global scope, I believe we can use either of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me either way, just seemed simpler.