Commit f0be0ca
authored
[JENKINS-21052] Warn user that the copy button requires HTTPS (#7665)
Warn user that the copy button requires HTTPS
Users that run Jenkins over an unencrypted (HTTP) connection will see
the copy button, but it does not perform a copy. Browsers will only
allow access to the clipboard if the page is in a secure context.
With this change, the text that is displayed when the user clicks the
copy button from an insecure context will alert the user that copy
requires a secure connection.
https://stackoverflow.com/questions/400212/how-do-i-copy-to-the-clipboard-in-javascript
describes the alternatives in more detail.
https://issues.jenkins.io/browse/JENKINS-21052 reported that the copy
button does not work. I've confirmed that it works when using an HTTPS
connection.1 parent bc7f06c commit f0be0ca
File tree
1 file changed
+26
-19
lines changed- core/src/main/resources/lib/layout/copyButton
1 file changed
+26
-19
lines changedLines changed: 26 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
19 | 20 | | |
20 | | - | |
21 | | - | |
22 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
23 | 24 | | |
24 | | - | |
25 | | - | |
| 25 | + | |
| 26 | + | |
26 | 27 | | |
27 | | - | |
28 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
29 | 36 | | |
30 | 37 | | |
31 | 38 | | |
0 commit comments