Skip to content

Commit e015b5e

Browse files
authored
Clarifying that PluginServletFilter is not in fact an ExtensionPoint (#11210)
1 parent 5176dd1 commit e015b5e

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

core/src/main/java/hudson/util/PluginServletFilter.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
package hudson.util;
2626

2727
import edu.umd.cs.findbugs.annotations.CheckForNull;
28-
import hudson.ExtensionPoint;
2928
import hudson.security.SecurityRealm;
3029
import io.jenkins.servlet.FilterWrapper;
3130
import io.jenkins.servlet.ServletExceptionWrapper;
@@ -51,19 +50,16 @@
5150
import org.kohsuke.stapler.CompatibleFilter;
5251

5352
/**
54-
* Servlet {@link Filter} that chains multiple {@link Filter}s, provided by plugins
55-
*
53+
* Servlet {@link Filter} that chains multiple {@link Filter}s, provided by plugins.
5654
* <p>
57-
* While this class by itself is not an extension point, I'm marking this class
58-
* as an extension point so that this class will be more discoverable.
59-
*
55+
* In most cases you should rather use {@link HttpServletFilter}.
6056
* <p>
6157
* {@link SecurityRealm} that wants to contribute {@link Filter}s should first
6258
* check if {@link SecurityRealm#createFilter(FilterConfig)} is more appropriate.
6359
*
6460
* @see SecurityRealm
6561
*/
66-
public final class PluginServletFilter implements CompatibleFilter, ExtensionPoint {
62+
public final class PluginServletFilter implements CompatibleFilter {
6763
private final List<Filter> list = new CopyOnWriteArrayList<>();
6864

6965
private /*almost final*/ FilterConfig config;

0 commit comments

Comments
 (0)