Fix NPE in Result.fromString when string is null [JENKINS-39044]

Zenith1415 · Zenith1415 · commit 320d93a3da38 · 2025-12-06T22:36:21.000+05:30
diff --git a/core/src/main/java/hudson/model/Result.java b/core/src/main/java/hudson/model/Result.java
@@ -169,7 +169,8 @@ public boolean isCompleteBuild() {
         return name;
     }
 
-    public static @NonNull Result fromString(@NonNull String s) {
+    public static @NonNull Result fromString(String s) {
+         if (s == null) return FAILURE;
         for (Result r : all)
             if (s.equalsIgnoreCase(r.name))
                 return r;

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,8 @@ public boolean isCompleteBuild() {`
`169`	`169`	`return name;`
`170`	`170`	`}`
`171`	`171`
`172`		`- public static @NonNull Result fromString(@NonNull String s) {`
	`172`	`+ public static @NonNull Result fromString(String s) {`
	`173`	`+ if (s == null) return FAILURE;`
`173`	`174`	`for (Result r : all)`
`174`	`175`	`if (s.equalsIgnoreCase(r.name))`
`175`	`176`	`return r;`