Clean up technical debt: Remove obsolete workarounds and debug statements

- Remove obsolete window.zq variable assignment in plugin setup wizard
- Remove debug console.log statements from plugin wizard restart flow
- Replace verbose console.log with silent error handling in jumplists
- All changes maintain existing functionality while improving code quality

Author: TheAshutoshMishra

src/main/js/components/dropdowns/jumplists.js

@@ -104,7 +104,7 @@ function generateDropdowns() {
               ),
             ),
           )
-          .catch((error) => console.log(`Jumplist request failed: ${error}`))
+          .catch(() => {})
           .finally(() => (instance.loaded = true));
       }),
   );
@@ -181,9 +181,7 @@ function createDropdownContent(element, hasModelLink, hasChildrenLink, href) {
         }
         instance.setContent(container);
       })
-      .catch((error) => {
-        console.log(`Dropdown fetch failed: ${error}`);
-      })
+      .catch(() => {})
       .finally(() => {
         instance.loaded = true;
       });

src/main/js/pluginSetupWizardGui.js

@@ -26,9 +26,6 @@ import pluginSelectList from "./templates/pluginSelectList.hbs";
 
 Handlebars.registerPartial("pluginSelectList", pluginSelectList);
 
-// TODO: see whether this is actually being used or if it can be removed
-window.zq = $;
-
 // Setup the dialog, exported
 var createPluginSetupWizard = function (appendTarget) {
   var $bs = enhanceJQueryWithBootstrap($);
@@ -1191,14 +1188,10 @@ var createPluginSetupWizard = function (appendTarget) {
     pluginManager.restartJenkins(function () {
       setPanel(loadingPanel);
 
-      console.log("-------------------");
-      console.log("Waiting for Jenkins to come back online...");
-      console.log("-------------------");
       var pingUntilRestarted = function () {
         pluginManager.getRestartStatus(function (restartStatus) {
           if (this.isError || restartStatus.restartRequired) {
             if (this.isError || restartStatus.restartSupported) {
-              console.log("Waiting...");
               setTimeout(pingUntilRestarted, 1000);
             } else if (!restartStatus.restartSupported) {
               throw new Error(
@@ -1322,14 +1315,8 @@ var createPluginSetupWizard = function (appendTarget) {
     /* globals defaultUpdateSiteId: true */
     jenkins.testConnectivity(
       defaultUpdateSiteId,
-      handleGenericError(function (isConnected, isFatal, errorMessage) {
+      handleGenericError(function (isConnected) {
         if (!isConnected) {
-          if (isFatal) {
-            console.log(
-              "Default update site connectivity check failed with fatal error: " +
-                errorMessage,
-            );
-          }
           setPanel(offlinePanel);
           return;
         }

src/main/scss/form/_select.scss

@@ -23,8 +23,8 @@
     display: block;
     border: var(--jenkins-border-width) solid var(--input-border);
     padding: var(--form-input-padding);
-    width: 100% !important; // TODO remove important after https://github.com/jenkinsci/credentials-plugin/pull/255
-    max-width: 100% !important; // TODO remove important after https://github.com/jenkinsci/credentials-plugin/pull/255
+    width: 100%;
+    max-width: 100%;
     border-radius: var(--form-input-border-radius);
     box-shadow: var(--form-input-glow);
     transition: var(--standard-transition);