fix(package) ensure fastly decache fails fast if the API answers an error - jenkins-infra/helpdesk#4910

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>

Author: dduportal

Jenkinsfile.d/core/package

@@ -348,7 +348,7 @@ pipeline {
         }
       }
     }
-    stage('Invalidate Fastly Cache') {
+    stage('Invalidate Fastly Cache for pkg.jenkins.io') {
       when {
         environment name: 'ONLY_STAGING', value: 'false'
       }

utils/release.bash

@@ -291,9 +291,10 @@ function guessGitBranchInformation() {
 
 function invalidateFastlyCache() {
 	: "${FASTLY_API_TOKEN:?Require FASTLY_API_TOKEN env variable}"
+	# Expecting pkg.jenkins.io site ID
 	: "${FASTLY_SERVICE_ID:?Require FASTLY_SERVICE_ID env variable}"
 
-	curl \
+	curl --fail --location \
 		-X POST \
 		-H "Fastly-Key: ${FASTLY_API_TOKEN}" \
 		-H "Accept: application/json" \