Fix TypeScript type errors with proper error handling and complete mock configs

Co-authored-by: unixfox <[email protected]>

Author: Copilot

src/lib/helpers/cacheDirectoryCheck.ts

@@ -41,9 +41,12 @@ export function checkCacheDirectoryPermissions(config: Config): void {
             try {
                 Deno.mkdirSync(youtubeiJsDir, { recursive: true });
             } catch (err) {
+                const errorMessage = err instanceof Error
+                    ? err.message
+                    : String(err);
                 throw new Error(
                     `Cannot create youtubei.js cache directory '${youtubeiJsDir}'. ` +
-                        `Check directory permissions. Original error: ${err.message}`,
+                        `Check directory permissions. Original error: ${errorMessage}`,
                 );
             }
         }
@@ -54,20 +57,24 @@ export function checkCacheDirectoryPermissions(config: Config): void {
             Deno.writeTextFileSync(testFile, "test");
             Deno.removeSync(testFile);
         } catch (err) {
+            const errorMessage = err instanceof Error
+                ? err.message
+                : String(err);
             throw new Error(
                 `Cannot write to youtubei.js cache directory '${youtubeiJsDir}'. ` +
                     `This usually indicates a permission issue. ` +
                     `Ensure the directory is writable by the application user. ` +
                     `For Docker containers, check volume mount permissions. ` +
-                    `Original error: ${err.message}`,
+                    `Original error: ${errorMessage}`,
             );
         }
 
         console.log(
             `[INFO] Cache directory '${youtubeiJsDir}' is accessible and writable`,
         );
     } catch (err) {
-        console.log(`[ERROR] Cache directory check failed: ${err.message}`);
+        const errorMessage = err instanceof Error ? err.message : String(err);
+        console.log(`[ERROR] Cache directory check failed: ${errorMessage}`);
         console.log(`[ERROR] Common solutions:`);
         console.log(
             `[ERROR] - For Docker: Ensure the mounted volume has correct permissions (chmod 777 or appropriate ownership)`,

src/main.ts

@@ -24,7 +24,8 @@ if (args._version_date && args._version_commit) {
 try {
     checkCacheDirectoryPermissions(config);
 } catch (err) {
-    console.log(`[FATAL] ${err.message}`);
+    const errorMessage = err instanceof Error ? err.message : String(err);
+    console.log(`[FATAL] ${errorMessage}`);
     Deno.exit(1);
 }
 

src/tests/cacheDirectoryCheck_test.ts

@@ -1,14 +1,58 @@
 import { checkCacheDirectoryPermissions } from "../lib/helpers/cacheDirectoryCheck.ts";
+import type { Config } from "../lib/helpers/config.ts";
+
+function createMockConfig(
+    cacheConfig: { enabled: boolean; directory: string },
+): Config {
+    return {
+        server: {
+            port: 8282,
+            host: "127.0.0.1",
+            use_unix_socket: false,
+            unix_socket_path: "/tmp/invidious-companion.sock",
+            secret_key: "1234567890123456",
+            verify_requests: false,
+            encrypt_query_params: false,
+            enable_metrics: false,
+        },
+        cache: cacheConfig,
+        networking: {
+            proxy: null,
+            fetch: {
+                timeout_ms: 30000,
+                retry: {
+                    enabled: false,
+                    times: 1,
+                    initial_debounce: 0,
+                    max_debounce: 0,
+                    backoff_multiplier: 0,
+                },
+            },
+            videoplayback: {
+                ump: false,
+                video_fetch_chunk_size_mb: 5,
+            },
+        },
+        jobs: {
+            youtube_session: {
+                po_token_enabled: false,
+                frequency: "*/5 * * * *",
+            },
+        },
+        youtube_session: {
+            oauth_enabled: false,
+            cookies: "",
+        },
+    };
+}
 
 Deno.test({
     name: "Cache directory permissions check - disabled cache",
     fn() {
-        const config = {
-            cache: {
-                enabled: false,
-                directory: "/nonexistent/path",
-            },
-        };
+        const config = createMockConfig({
+            enabled: false,
+            directory: "/nonexistent/path",
+        });
 
         // Should not throw when cache is disabled
         checkCacheDirectoryPermissions(config);
@@ -18,12 +62,10 @@ Deno.test({
 Deno.test({
     name: "Cache directory permissions check - valid directory",
     fn() {
-        const config = {
-            cache: {
-                enabled: true,
-                directory: "/tmp",
-            },
-        };
+        const config = createMockConfig({
+            enabled: true,
+            directory: "/tmp",
+        });
 
         // Should not throw for /tmp which should be writable
         checkCacheDirectoryPermissions(config);
@@ -33,25 +75,26 @@ Deno.test({
 Deno.test({
     name: "Cache directory permissions check - nonexistent parent directory",
     fn() {
-        const config = {
-            cache: {
-                enabled: true,
-                directory: "/nonexistent/path",
-            },
-        };
+        const config = createMockConfig({
+            enabled: true,
+            directory: "/nonexistent/path",
+        });
 
         // Should throw for nonexistent parent directory
         try {
             checkCacheDirectoryPermissions(config);
             throw new Error("Expected function to throw");
         } catch (err) {
-            if (err.message.includes("Expected function to throw")) {
+            const errorMessage = err instanceof Error
+                ? err.message
+                : String(err);
+            if (errorMessage.includes("Expected function to throw")) {
                 throw err;
             }
             // Expected error - check it contains helpful information
-            if (!err.message.includes("does not exist")) {
+            if (!errorMessage.includes("does not exist")) {
                 throw new Error(
-                    `Expected error message to mention directory doesn't exist, got: ${err.message}`,
+                    `Expected error message to mention directory doesn't exist, got: ${errorMessage}`,
                 );
             }
         }