-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(breaking change): experimental config options #749
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
'use strict' | ||
|
||
exports.goOnline = require('./go-online') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's not duplicate module.exports = {
goOnline: require('./go-online'),
...
} There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, that way we have to worry about those commas, the way it is right now doesn't There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure what commas you mean There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if it is inside an object, for every add/delete, we get the 'no dangling comma situation' There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we have a lot of mixed and unclean diffs, not sure this makes any diff ;) |
||
exports.goOffline = require('./go-offline') | ||
exports.isOnline = require('./is-online') | ||
exports.load = require('./load') | ||
exports.version = require('./version') | ||
exports.id = require('./id') | ||
exports.repo = require('./repo') | ||
exports.init = require('./init') | ||
exports.bootstrap = require('./bootstrap') | ||
exports.config = require('./config') | ||
exports.block = require('./block') | ||
exports.object = require('./object') | ||
exports.libp2p = require('./libp2p') | ||
exports.swarm = require('./swarm') | ||
exports.ping = require('./ping') | ||
exports.files = require('./files') | ||
exports.bitswap = require('./bitswap') | ||
exports.pubsub = require('./pubsub') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to upcase this? I think
experimental
is enough. What would be good is to print something to the console when this is enabled.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like making things very OBVIOUS :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BUT DO YOU REALLY NEED TO SCREAM AT ME?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add your log :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added your log :)