From f0b4f422c27d618b99150b9b25b2ff381948f90f Mon Sep 17 00:00:00 2001 From: Volker Mische Date: Wed, 7 Aug 2019 15:49:15 +0200 Subject: [PATCH] chore: update comment about skipping the DHT test To find all of those comments run: ```console $ grep DHT test -R |grep TODO test/cli/dht.js:// TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994 test/core/ping.spec.js: // TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994 test/core/interface.spec.js: reason: 'TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994' test/core/dht.spec.js:// TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994 test/core/name.spec.js: // TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994 test/http-api/inject/dht.js: // TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994 test/http-api/interface.js: reason: 'TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994' ``` --- test/cli/dht.js | 2 +- test/core/dht.spec.js | 2 +- test/core/interface.spec.js | 2 +- test/core/name.spec.js | 2 +- test/core/ping.spec.js | 2 +- test/http-api/inject/dht.js | 2 +- test/http-api/interface.js | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/test/cli/dht.js b/test/cli/dht.js index a74a387b89..5a8cfde127 100644 --- a/test/cli/dht.js +++ b/test/cli/dht.js @@ -31,7 +31,7 @@ const daemonOpts = { initOptions: { bits: 512 } } -// TODO: unskip when DHT is enabled in 0.36 +// TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994 describe.skip('dht', () => { const nodes = [] let ipfsA diff --git a/test/core/dht.spec.js b/test/core/dht.spec.js index 2eedd6205e..5e4cbd157f 100644 --- a/test/core/dht.spec.js +++ b/test/core/dht.spec.js @@ -12,7 +12,7 @@ const isNode = require('detect-node') const IPFSFactory = require('ipfsd-ctl') const IPFS = require('../../src/core') -// TODO: unskip when DHT is enabled in 0.36 +// TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994 describe.skip('dht', () => { describe('enabled', () => { let ipfsd, ipfs diff --git a/test/core/interface.spec.js b/test/core/interface.spec.js index e1dba42bbe..b8fd32a2e5 100644 --- a/test/core/interface.spec.js +++ b/test/core/interface.spec.js @@ -52,7 +52,7 @@ describe('interface-ipfs-core tests', function () { } }), { skip: { - reason: 'TODO: unskip when DHT is enabled in 0.36' + reason: 'TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994' } }) diff --git a/test/core/name.spec.js b/test/core/name.spec.js index 0db5a90bf2..da21a7ab87 100644 --- a/test/core/name.spec.js +++ b/test/core/name.spec.js @@ -88,7 +88,7 @@ describe('name', function () { }) }) - // TODO: unskip when DHT is enabled in 0.36 + // TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994 describe.skip('work with dht', () => { let nodes let nodeA diff --git a/test/core/ping.spec.js b/test/core/ping.spec.js index 009d7ec595..04cb898f57 100644 --- a/test/core/ping.spec.js +++ b/test/core/ping.spec.js @@ -195,7 +195,7 @@ describe('ping', function () { }) }) - // TODO: unskip when DHT enabled in 0.36 + // TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994 describe.skip('DHT enabled', function () { // Our bootstrap process will run 3 IPFS daemons where // A ----> B ----> C diff --git a/test/http-api/inject/dht.js b/test/http-api/inject/dht.js index c57deaecd0..36ca747da4 100644 --- a/test/http-api/inject/dht.js +++ b/test/http-api/inject/dht.js @@ -8,7 +8,7 @@ const expect = chai.expect chai.use(dirtyChai) module.exports = (http) => { - // TODO: unskip when DHT is enabled in 0.36 + // TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994 describe.skip('/dht', () => { let api diff --git a/test/http-api/interface.js b/test/http-api/interface.js index 48f708f747..b94004085f 100644 --- a/test/http-api/interface.js +++ b/test/http-api/interface.js @@ -61,7 +61,7 @@ describe('interface-ipfs-core over ipfs-http-client tests', () => { } }), { skip: { - reason: 'TODO: unskip when DHT is enabled in 0.36' + reason: 'TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994' } })