test: verify that multiple discovery systems do not cause conflict'

Author: daviddias

gulpfile.js

@@ -9,7 +9,7 @@ const API = require('./src/http-api')
 let nodes = []
 
 function startNode (num, done) {
-  createTempNode(num, (err, node) => {
+  createTempNode({ num: num }, (err, node) => {
     if (err) {
       return done(err)
     }

package.json

@@ -72,7 +72,7 @@
     "form-data": "^2.1.2",
     "fs-pull-blob-store": "^0.4.1",
     "gulp": "^3.9.1",
-    "interface-ipfs-core": "^0.23.4",
+    "interface-ipfs-core": "^0.23.5",
     "ipfsd-ctl": "^0.18.1",
     "left-pad": "^1.1.3",
     "lodash": "^4.17.4",
@@ -107,16 +107,16 @@
     "ipld-resolver": "^0.4.1",
     "isstream": "^0.1.2",
     "libp2p-floodsub": "0.7.1",
-    "joi": "^10.1.0",
-    "libp2p-ipfs-nodejs": "^0.17.3",
-    "libp2p-ipfs-browser": "^0.17.4",
+    "joi": "^10.2.0",
+    "libp2p-ipfs-nodejs": "^0.17.4",
+    "libp2p-ipfs-browser": "^0.17.5",
     "lodash.flatmap": "^4.5.0",
     "lodash.get": "^4.4.2",
     "lodash.has": "^4.5.2",
     "lodash.set": "^4.3.2",
     "lodash.sortby": "^4.7.0",
     "lodash.values": "^4.3.0",
-    "mafmt": "^2.1.2",
+    "mafmt": "^2.1.5",
     "multiaddr": "^2.1.3",
     "multihashes": "^0.3.1",
     "path-exists": "^3.0.0",
@@ -170,4 +170,4 @@
     "nginnever <[email protected]>",
     "npmcdn-to-unpkg-bot <[email protected]>"
   ]
-}
+}

test/cli/test-bitswap.js

@@ -14,7 +14,7 @@ describe('bitswap', () => {
   let node
 
   before((done) => {
-    createTempNode(38, (err, _node) => {
+    createTempNode({ num: 38 }, (err, _node) => {
       expect(err).to.not.exist
       node = _node
       node.goOnline(done)

test/cli/test-pubsub.js

@@ -18,7 +18,7 @@ describe.skip('pubsub', () => {
   let id
 
   before((done) => {
-    createTempNode(1, (err, _node) => {
+    createTempNode({ num: 1 }, (err, _node) => {
       expect(err).to.not.exist
       node = _node
       node.goOnline(done)

test/cli/test-swarm.js

@@ -14,7 +14,7 @@ describe('swarm', function () {
   let nodeAddr
 
   before((done) => {
-    createTempNode(1, (err, _node) => {
+    createTempNode({ num: 1 }, (err, _node) => {
       expect(err).to.not.exist
       node = _node
       node.goOnline((err) => {

test/core/node-only/test-discovery.js

@@ -0,0 +1,112 @@
+/* eslint max-nested-callbacks: ["error", 8] */
+/* eslint-env mocha */
+'use strict'
+
+const expect = require('chai').expect
+const parallel = require('async/parallel')
+const series = require('async/series')
+const IPFS = require('../../../src/core')
+
+const createTempRepo = require('../../utils/temp-repo')
+
+const sigServer = require('libp2p-webrtc-star/src/sig-server')
+
+/*
+ * Note:
+ * Do not run these tests with other nodes in the same host with MDNS enabled
+ */
+
+// This keeps getting better, really need to finish the
+// improving init thing
+function createNode (webrtcStar, callback) {
+  const repo = createTempRepo()
+  const node = new IPFS(repo)
+
+  series([
+    (cb) => node.init({ emptyRepo: true, bits: 1024 }, cb),
+    (cb) => {
+      repo.config.get((err, config) => {
+        expect(err).to.not.exist
+
+        config.Addresses = {
+          Swarm: ['/ip4/127.0.0.1/tcp/0'],
+          API: '',
+          Gateway: ''
+        }
+        if (webrtcStar) {
+          const peerIdStr = config.Identity.PeerID
+          const wstarAddr = '/libp2p-webrtc-star/ip4/127.0.0.1/tcp/33333/ws/ipfs/' + peerIdStr
+
+          config.Addresses.Swarm.push(wstarAddr)
+        }
+        repo.config.set(config, cb)
+      })
+    },
+    (cb) => node.load(cb)
+  ], (err) => callback(err, node))
+}
+
+describe.only('discovery', () => {
+  let nodeA // only mdns
+  let nodeB // mdns + webrtc-star discovery
+  let nodeC // mdns + webrtc-star discovery
+
+  let ss
+
+  before((done) => {
+    parallel([
+      (cb) => {
+        sigServer.start({
+          port: 33333
+        }, (err, server) => {
+          expect(err).to.not.exist
+          ss = server
+          cb()
+        })
+      },
+      // create 4 nodes
+      (cb) => {
+        createNode(false, (err, node) => {
+          expect(err).to.not.exist
+          nodeA = node
+          cb()
+        })
+      },
+      (cb) => {
+        createNode(true, (err, node) => {
+          expect(err).to.not.exist
+          nodeB = node
+          cb()
+        })
+      },
+      (cb) => {
+        createNode(true, (err, node) => {
+          expect(err).to.not.exist
+          nodeC = node
+          cb()
+        })
+      }
+    ], done)
+  })
+
+  after((done) => {
+    series([
+      (cb) => nodeA.goOffline(cb),
+      (cb) => nodeB.goOffline(cb),
+      (cb) => nodeC.goOffline(cb),
+      (cb) => ss.stop(cb)
+    ], done)
+  })
+
+  it('boot nodeA', (done) => {
+    nodeA.goOnline(done)
+  })
+
+  it('boot nodeB, verify that MDNS worked', (done) => {
+    nodeB.goOnline(done)
+  })
+
+  it('boot nodeC, verify that MDNS or webrtc-star worked without conflict', (done) => {
+    nodeC.goOnline(done)
+  })
+})

test/http-api/custom-ipfs-api/test-swarm.js

@@ -12,7 +12,7 @@ module.exports = (ctl) => {
     let remoteNodeAddr
 
     before((done) => {
-      createTempNode(6, (err, _remoteNode) => {
+      createTempNode({ num: 6 }, (err, _remoteNode) => {
         expect(err).to.not.exist
         remoteNode = _remoteNode
         remoteNode.goOnline(() => {

test/http-api/inject/test-pubsub.js

@@ -17,7 +17,7 @@ module.exports = (http) => {
     before((done) => {
       api = http.api.server.select('API')
 
-      createTempNode(47, (err, _ipfs) => {
+      createTempNode({ num: 47 }, (err, _ipfs) => {
         expect(err).to.not.exist
         tmpNode = _ipfs
         tmpNode.goOnline((err) => {

test/http-api/inject/test-swarm.js

@@ -17,7 +17,7 @@ module.exports = (http) => {
     before((done) => {
       api = http.api.server.select('API')
 
-      createTempNode(47, (err, _ipfs) => {
+      createTempNode({ num: 47 }, (err, _ipfs) => {
         expect(err).to.not.exist
         tmpNode = _ipfs
         tmpNode.goOnline((err) => {

test/utils/temp-node.js

@@ -7,46 +7,51 @@ const series = require('async/series')
 const IPFS = require('../../src/core')
 const createTempRepo = require('./temp-repo')
 
-function setAddresses (repo, num, callback) {
+function setAddresses (repo, addresses, callback) {
   repo.config.get((err, config) => {
     if (err) {
       return callback(err)
     }
 
-    config.Addresses = {
-      Swarm: [
-        `/ip4/127.0.0.1/tcp/10${num}`,
-        `/ip4/127.0.0.1/tcp/20${num}/ws`
-      ],
-      API: `/ip4/127.0.0.1/tcp/31${num}`,
-      Gateway: `/ip4/127.0.0.1/tcp/32${num}`
-    }
+    config.Addresses = addresses
 
     config.Discovery.MDNS.Enabled = false
 
     repo.config.set(config, callback)
   })
 }
 
-function createTempNode (num, callback) {
-  const repo = createTempRepo()
-  const ipfs = new IPFS(repo)
+/*
+ * options.repo - repo to use
+ * options.num - generate addrs based on num for port
+ * options.addresses - uses this addrs instead of default
+ */
+function createTempNode (options, callback) {
+  const repo = options.repo ? options.repo : createTempRepo()
+  const node = new IPFS(repo)
 
-  num = leftPad(num, 3, 0)
+  let addresses
 
-  series([
-    (cb) => ipfs.init({
-      emptyRepo: true,
-      bits: 1024
-    }, cb),
-    (cb) => setAddresses(repo, num, cb),
-    (cb) => ipfs.load(cb)
-  ], (err) => {
-    if (err) {
-      return callback(err)
+  if (options.num) {
+    const pad = leftPad(options.num, 3, 0)
+
+    addresses = {
+      Swarm: [
+        `/ip4/127.0.0.1/tcp/10${pad}`,
+        `/ip4/127.0.0.1/tcp/20${pad}/ws`
+      ],
+      API: `/ip4/127.0.0.1/tcp/31${pad}`,
+      Gateway: `/ip4/127.0.0.1/tcp/32${pad}`
     }
-    callback(null, ipfs)
-  })
+  } else if (options.addresses) {
+    addresses = options.addresses
+  }
+
+  series([
+    (cb) => node.init({ emptyRepo: true, bits: 1024 }, cb),
+    (cb) => setAddresses(repo, addresses, cb),
+    (cb) => node.load(cb)
+  ], (err) => callback(err, node))
 }
 
 module.exports = createTempNode