This repository was archived by the owner on Mar 23, 2023. It is now read-only.
fix: do not strip prefixes for MountDatastores #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a mount datastore:
```js
const d = new MountDatastore([{
datastore: foo,
prefix: new Key('/bar')
}])
```
`d.put(new Key('/bar/baz'), val)` results in `foo.put(new Key('/baz'), val)`.
This PR changes the default behaviour to `foo.put(new Key('/bar/baz'), val)`.
If you need the old behaviour, use a `KeyTransformDatastore` to strip the prefix
- see [stripPrefixDatastore](./test/mount.spec.js#17) for an example.
BREAKING CHANGE: key prefixes are no longer stripped by MountDatastore
achingbrain
deleted the
fix/do-not-strip-prefixes-for-mount-datastores
branch
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a mount datastore:
d.put(new Key('/bar/baz'), val)results infoo.put(new Key('/baz'), val).This PR changes the default behaviour to
foo.put(new Key('/bar/baz'), val).If you need the old behaviour, use a
KeyTransformDatastoreto strip the prefix - see stripPrefixDatastore in the MountDatastore tests for an example.BREAKING CHANGE: key prefixes are no longer stripped by MountDatastore