core:fix error load private key in offline model #4980
Conversation
License: MIT Signed-off-by: zhangkejie <[email protected]>
There was a problem hiding this comment.
@Kubuxu or @whyrusleeping, do you remember why we initialize offline routing on-demand instead of on start (like we do with online routing)?
| err := n.LoadPrivateKey() | ||
| if err != nil { | ||
| return err | ||
| if n.PrivateKey == nil { |
There was a problem hiding this comment.
I'd actually put this check inside LoadPrivateKey and get rid of the error there if the private key is already loaded.
There was a problem hiding this comment.
i think put it in LoadPrivateKey can not slove this problem,you can see issue #4978,i have fix this issue .what's more u can see the 196 line of the code in core/command/id.go,we should add the judgment in the project
There was a problem hiding this comment.
Sorry, my suggestion was to make LoadPrivateKey return success if the private key is already loaded instead of returning an error. That should fix the issue unless I'm missing something.
|
@kjzz could you add a sharness test for this bugfix. I think the best way to do it is to add it in |
|
@Kubuxu ok,i will.thank u |
Fix issue #4978
License:MIT
Signed-off-by: zhangkejie [email protected]