fix: prevent panic in report template when dump fails

lidel · lidel · commit 3f2a408f5278 · 2025-12-03T01:15:21.000+01:00
replace panics with error messages in the dump template function, allowing test reports to render gracefully on timeouts fixes #251
diff --git a/tooling/test/report.go b/tooling/test/report.go
@@ -74,11 +74,11 @@ func report(t *testing.T, test SugarTest, req *http.Request, res *http.Response,
 				// "http: ContentLength=6 with Body length 0"
 				b, err = httputil.DumpResponse(v, false)
 			default:
-				panic("unknown type")
+				return fmt.Sprintf("error: unknown type %T", v)
 			}
 
 			if err != nil {
-				panic(err)
+				return fmt.Sprintf("error: failed to dump %T: %v", v, err)
 			}
 
 			return string(b)

Original file line number	Diff line number	Diff line change
`@@ -74,11 +74,11 @@ func report(t testing.T, test SugarTest, req http.Request, res *http.Response,`
`74`	`74`	`// "http: ContentLength=6 with Body length 0"`
`75`	`75`	`b, err = httputil.DumpResponse(v, false)`
`76`	`76`	`default:`
`77`		`- panic("unknown type")`
	`77`	`+ return fmt.Sprintf("error: unknown type %T", v)`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`if err != nil {`
`81`		`- panic(err)`
	`81`	`+ return fmt.Sprintf("error: failed to dump %T: %v", v, err)`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`return string(b)`