Skip to content

Commit 417280e

Browse files
authored
Merge pull request #55 from ipfs-shipyard/chore/pin-bouncycastle-1.8.5-and-note
chore(deps): pin Portable.BouncyCastle to 1.8.5; add inline note
2 parents bc6589c + d051409 commit 417280e

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

src/IpfsCore.csproj

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,14 @@ Added missing IFileSystemApi.ListAsync. Doesn't fully replace the removed IFileS
128128
<PrivateAssets>all</PrivateAssets>
129129
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
130130
</PackageReference>
131-
<PackageReference Include="Portable.BouncyCastle" Version="1.9.0" />
131+
<!-- NOTE:
132+
Bumped to 1.9.0 in PR #52, but SHAKE-128 began defaulting to 32-byte output via the
133+
generic IDigest path, breaking tests expecting 16 bytes (per multihash fixtures).
134+
Pinning to 1.8.5 until we add an IXof-aware wrapper that emits Algorithm.DigestSize
135+
for SHAKE (16 for shake-128, 32 for shake-256), then we can safely re-upgrade.
136+
See CI failures: MultiHashTest/HashingTest around SHAKE-128 digest length.
137+
-->
138+
<PackageReference Include="Portable.BouncyCastle" Version="1.8.5" />
132139
<PackageReference Include="SimpleBase" Version="1.3.1" />
133140
<PackageReference Include="Grpc.Tools" Version="2.62.0" PrivateAssets="All" />
134141
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />

0 commit comments

Comments
 (0)