fix: ui issues (#3316)

Author: Ahmed-Naguib93

Horizon/Horizon/Sources/Features/Account/AccountView.swift

@@ -91,6 +91,10 @@ struct AccountView: View {
                 )
             }
         }
+        .onAppear {
+            viewModel.getUserName()
+        }
+
     }
 
     private var divider: some View {

Horizon/Horizon/Sources/Features/Account/AccountViewModel.swift

@@ -32,6 +32,7 @@ final class AccountViewModel {
     // MARK: - Dependencies
 
     private let router: Router
+    private let getUserInteractor: GetUserInteractor
 
     // MARK: - Private properties
 
@@ -53,13 +54,7 @@ final class AccountViewModel {
         router: Router = AppEnvironment.shared.router
     ) {
         self.router = router
-
-        getUserInteractor
-            .getUser()
-            .map { $0.name }
-            .replaceError(with: "")
-            .assign(to: \.name, on: self)
-            .store(in: &subscriptions)
+        self.getUserInteractor = getUserInteractor
 
         confirmLogoutViewModel.userConfirmation()
             .sink {
@@ -81,6 +76,15 @@ final class AccountViewModel {
         }
     }
 
+    func getUserName() {
+        getUserInteractor
+            .getUser()
+            .map { $0.name }
+            .replaceError(with: "")
+            .assign(to: \.name, on: self)
+            .store(in: &subscriptions)
+    }
+
     func passwordDidTap() {}
 
     func notificationsDidTap(viewController: WeakViewController) {

Horizon/Horizon/Sources/Features/Learn/CourseDetails/View/CourseDetailsView.swift

@@ -24,7 +24,7 @@ struct CourseDetailsView: View {
     @State private var viewModel: CourseDetailsViewModel
     @Environment(\.viewController) private var viewController
     @Environment(\.dismiss) private var dismiss
-    @State private var selectedTabIndex: Int = 0
+    @State private var selectedTabIndex: Int = 1
 
     // MARK: - Dependencies
 
@@ -173,8 +173,8 @@ struct CourseDetailsView: View {
 
 extension CourseDetailsView {
     enum Tabs: CaseIterable, Identifiable {
-        case myProgress
         case overview
+        case myProgress
         case scores
         case notebook
 //        case quickLinks

Horizon/Horizon/Sources/Features/LearningObjects/Assignment/AssignmentDetails/View/AssignmentSubmissionView.swift

@@ -128,7 +128,7 @@ struct AssignmentSubmissionView: View {
         case .fileUpload:
             VStack(spacing: .huiSpaces.space8) {
                 HorizonUI.FileDrop(
-                    acceptedFilesType: viewModel.assignment?.allowedFileExtensions ?? ""
+                    acceptedFilesType: viewModel.assignment?.allowedFileExtensions
                 ) {
                     isOverlayUploadFilePresented.toggle()
                 }

Horizon/Horizon/Sources/Features/ModuleItemSequence/Sequence/View/ModuleItemSequenceViewModel.swift

@@ -132,7 +132,7 @@ final class ModuleItemSequenceViewModel {
         guard let course else {
             return
         }
-
+        assignmentAttemptCount = nil
         let viewController = CourseProgressAssembly.makeView(
             course: course,
             currentModuleItem: moduleItem

packages/HorizonUI/Sources/HorizonUI/Sources/Components/FileDrop/HorizonUI.FileDrop.swift

@@ -24,13 +24,13 @@ public extension HorizonUI {
 
         // MARK: - Dependencies
 
-        private let acceptedFilesType: String
+        private let acceptedFilesType: String?
         private let onTap: () -> Void
 
         // MARK: - Init
 
         public init(
-            acceptedFilesType: String,
+            acceptedFilesType: String?,
             onTap: @escaping () -> Void
         ) {
             self.acceptedFilesType = acceptedFilesType
@@ -56,14 +56,17 @@ public extension HorizonUI {
                         style: StrokeStyle(lineWidth: 1, dash: [6, 5]))
         }
 
+        @ViewBuilder
         private var acceptedFilesView: some View {
-            HStack(spacing: .huiSpaces.space2) {
-                Text(String(localized: "Accepted file types:"))
-                Text(acceptedFilesType)
+            if let acceptedFilesType, !acceptedFilesType.isEmpty {
+                HStack(spacing: .huiSpaces.space2) {
+                    Text(String(localized: "Accepted file types:"))
+                    Text(acceptedFilesType)
+                }
+                .foregroundStyle(Color.huiColors.text.body)
+                .huiTypography(.p2)
+                .padding(.horizontal, .huiSpaces.space16)
             }
-            .foregroundStyle(Color.huiColors.text.body)
-            .huiTypography(.p2)
-            .padding(.horizontal, .huiSpaces.space16)
         }
     }
 }