Skip to content

Commit 1eb09d4

Browse files
fix: showing view Attempts
1 parent c04dcf0 commit 1eb09d4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Horizon/Horizon/Sources/Features/LearningObjects/Assignment/AssignmentDetails/View/AssignmentDetails.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ struct AssignmentDetails: View {
3838
var body: some View {
3939
ScrollViewReader { proxy in
4040
ScrollView(showsIndicators: false) {
41-
if let submission = viewModel.submission, viewModel.didTapViewAttempts {
41+
if let submission = viewModel.submission, viewModel.shouldShowViewAttempts {
4242
viewAttemptText(attempt: submission.attempt)
4343
}
4444
topView

Horizon/Horizon/Sources/Features/LearningObjects/Assignment/AssignmentDetails/View/AssignmentDetailsViewModel.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ final class AssignmentDetailsViewModel {
5151
private(set) var selectedSubmission: AssignmentSubmissionType = .text
5252
private(set) var externalURL: URL?
5353
private(set) var submissionProperties: SubmissionProperties?
54-
private(set) var didTapViewAttempts = false
54+
private(set) var shouldShowViewAttempts = false
5555
var isStartTyping = false
5656
var assignmentPreference: AssignmentPreferenceKeyType?
5757
var isSubmitButtonHidden: Bool {
@@ -170,7 +170,7 @@ final class AssignmentDetailsViewModel {
170170
}
171171
hasSubmittedBefore = true
172172
submission = selectedSubmission
173-
didTapViewAttempts = true
173+
shouldShowViewAttempts = selectedSubmission != submissions.first
174174
submissionProperties?.hasUnreadComments = hasUnreadComments(for: selectedSubmission?.attempt)
175175
didLoadAssignment(submissionProperties)
176176
}

0 commit comments

Comments
 (0)