Skip to content

Commit bcac24f

Browse files
heiruwudroplet-bot
andauthored
chore(model): rename model version id to version (#372)
Because - id is ambiguous, use `version` instead This commit - rename `id` to `version` --------- Co-authored-by: droplet-bot <[email protected]>
1 parent 9acc271 commit bcac24f

File tree

6 files changed

+42
-44
lines changed

6 files changed

+42
-44
lines changed

artifact/artifact/v1alpha/artifact.proto

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ message KnowledgeBase {
162162
repeated string downstream_apps = 12;
163163
}
164164

165-
166165
// CreateKnowledgeBaseRequest represents a request to create a knowledge base.
167166
message CreateKnowledgeBaseRequest {
168167
// The knowledge base owner(nammespace).

artifact/artifact/v1alpha/artifact_public_service.proto

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -40,21 +40,21 @@ service ArtifactPublicService {
4040
option (google.api.method_visibility).restriction = "INTERNAL";
4141
}
4242

43-
// Create a knowledge base
43+
// Create a knowledge base
4444
rpc CreateKnowledgeBase(CreateKnowledgeBaseRequest) returns (CreateKnowledgeBaseResponse) {
45-
option (google.api.http) = {
46-
post: "/v1alpha/owners/{owner_id}/knowledge-bases"
47-
body: "*"
48-
};
49-
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {tags: "KnowledgeBase"};
50-
}
51-
52-
// Get all knowledge bases info
45+
option (google.api.http) = {
46+
post: "/v1alpha/owners/{owner_id}/knowledge-bases"
47+
body: "*"
48+
};
49+
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {tags: "KnowledgeBase"};
50+
}
51+
52+
// Get all knowledge bases info
5353
rpc ListKnowledgeBases(ListKnowledgeBasesRequest) returns (ListKnowledgeBasesResponse) {
54-
option (google.api.http) = {get: "/v1alpha/owners/{owner_id}/knowledge-bases"};
55-
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {tags: "KnowledgeBase"};
56-
}
57-
54+
option (google.api.http) = {get: "/v1alpha/owners/{owner_id}/knowledge-bases"};
55+
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {tags: "KnowledgeBase"};
56+
}
57+
5858
// Update a knowledge base info
5959
rpc UpdateKnowledgeBase(UpdateKnowledgeBaseRequest) returns (UpdateKnowledgeBaseResponse) {
6060
option (google.api.http) = {
@@ -63,7 +63,7 @@ service ArtifactPublicService {
6363
};
6464
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {tags: "KnowledgeBase"};
6565
}
66-
66+
6767
// Delete a knowledge base
6868
rpc DeleteKnowledgeBase(DeleteKnowledgeBaseRequest) returns (DeleteKnowledgeBaseResponse) {
6969
option (google.api.http) = {delete: "/v1alpha/owners/{owner_id}/knowledge-bases/{kb_id}"};

model/model/v1alpha/model.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@ message ModelVersion {
9797
// The name of the tag.
9898
// - Format: `users/{user.id}/models/{model.id}/versions/{version.id}`.
9999
string name = 1 [(google.api.field_behavior) = IMMUTABLE];
100-
// The tag identifier.
101-
string id = 2 [(google.api.field_behavior) = IMMUTABLE];
100+
// The model version identifier, which is equal to image tag.
101+
string version = 2 [(google.api.field_behavior) = IMMUTABLE];
102102
// Unique identifier, computed from the manifest the tag refers to.
103103
string digest = 3 [(google.api.field_behavior) = OPTIONAL];
104104
// Current state of this model version.

model/model/v1alpha/model_public_service.proto

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,9 @@ service ModelPublicService {
198198

199199
// Watch the state of a model version
200200
//
201-
// Returns the state of a model. The deploy / undeploy actions take some
202-
// time, during which a model will be in an UNSPECIFIED state. This endpoint
203-
// allows clients to track the state and progress of the model.
201+
// Returns the state of a model. The model resource allocation and scaling actions take some
202+
// time, during which a model will be in various state. This endpoint
203+
// allows clients to track the state.
204204
rpc WatchUserModel(WatchUserModelRequest) returns (WatchUserModelResponse) {
205205
option (google.api.http) = {get: "/v1alpha/{name=users/*/models/*}/versions/{version=*}/watch"};
206206
option (google.api.method_signature) = "name";
@@ -209,9 +209,9 @@ service ModelPublicService {
209209

210210
// Watch the state of the latest model version
211211
//
212-
// Returns the state of the latest model version. The deploy / undeploy actions take some
213-
// time, during which a model will be in an UNSPECIFIED state. This endpoint
214-
// allows clients to track the state and progress of the model.
212+
// Returns the state of the latest model version. The model resource allocation and scaling actions
213+
// take some time, during which a model will be in various state. This endpoint
214+
// allows clients to track the state.
215215
rpc WatchUserLatestModel(WatchUserLatestModelRequest) returns (WatchUserLatestModelResponse) {
216216
option (google.api.http) = {get: "/v1alpha/{name=users/*/models/*}/watch"};
217217
option (google.api.method_signature) = "name";
@@ -404,9 +404,9 @@ service ModelPublicService {
404404

405405
// Watch the state of a model version
406406
//
407-
// Returns the state of a model. The deploy / undeploy actions take some
408-
// time, during which a model will be in an UNSPECIFIED state. This endpoint
409-
// allows clients to track the state and progress of the model.
407+
// Returns the state of a model. The model resource allocation and scaling actions
408+
// take some time, during which a model will be in various state. This endpoint
409+
// allows clients to track the state.
410410
rpc WatchOrganizationModel(WatchOrganizationModelRequest) returns (WatchOrganizationModelResponse) {
411411
option (google.api.http) = {get: "/v1alpha/{name=organizations/*/models/*}/versions/{version=*}/watch"};
412412
option (google.api.method_signature) = "name";
@@ -415,9 +415,9 @@ service ModelPublicService {
415415

416416
// Watch the state of the latest model version
417417
//
418-
// Returns the state of the latest model version. The deploy / undeploy actions take some
419-
// time, during which a model will be in an UNSPECIFIED state. This endpoint
420-
// allows clients to track the state and progress of the model.
418+
// Returns the state of the latest model version. The model resource allocation and scaling actions
419+
// take some time, during which a model will be in various state. This endpoint
420+
// allows clients to track the state.
421421
rpc WatchOrganizationLatestModel(WatchOrganizationLatestModelRequest) returns (WatchOrganizationLatestModelResponse) {
422422
option (google.api.http) = {get: "/v1alpha/{name=organizations/*/models/*}/watch"};
423423
option (google.api.method_signature) = "name";

openapiv2/model/service.swagger.yaml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -733,9 +733,9 @@ paths:
733733
get:
734734
summary: Watch the state of a model version
735735
description: |-
736-
Returns the state of a model. The deploy / undeploy actions take some
737-
time, during which a model will be in an UNSPECIFIED state. This endpoint
738-
allows clients to track the state and progress of the model.
736+
Returns the state of a model. The model resource allocation and scaling actions take some
737+
time, during which a model will be in various state. This endpoint
738+
allows clients to track the state.
739739
operationId: ModelPublicService_WatchUserModel
740740
responses:
741741
"200":
@@ -771,9 +771,9 @@ paths:
771771
get:
772772
summary: Watch the state of the latest model version
773773
description: |-
774-
Returns the state of the latest model version. The deploy / undeploy actions take some
775-
time, during which a model will be in an UNSPECIFIED state. This endpoint
776-
allows clients to track the state and progress of the model.
774+
Returns the state of the latest model version. The model resource allocation and scaling actions
775+
take some time, during which a model will be in various state. This endpoint
776+
allows clients to track the state.
777777
operationId: ModelPublicService_WatchUserLatestModel
778778
responses:
779779
"200":
@@ -1491,9 +1491,9 @@ paths:
14911491
get:
14921492
summary: Watch the state of a model version
14931493
description: |-
1494-
Returns the state of a model. The deploy / undeploy actions take some
1495-
time, during which a model will be in an UNSPECIFIED state. This endpoint
1496-
allows clients to track the state and progress of the model.
1494+
Returns the state of a model. The model resource allocation and scaling actions
1495+
take some time, during which a model will be in various state. This endpoint
1496+
allows clients to track the state.
14971497
operationId: ModelPublicService_WatchOrganizationModel
14981498
responses:
14991499
"200":
@@ -1529,9 +1529,9 @@ paths:
15291529
get:
15301530
summary: Watch the state of the latest model version
15311531
description: |-
1532-
Returns the state of the latest model version. The deploy / undeploy actions take some
1533-
time, during which a model will be in an UNSPECIFIED state. This endpoint
1534-
allows clients to track the state and progress of the model.
1532+
Returns the state of the latest model version. The model resource allocation and scaling actions
1533+
take some time, during which a model will be in various state. This endpoint
1534+
allows clients to track the state.
15351535
operationId: ModelPublicService_WatchOrganizationLatestModel
15361536
responses:
15371537
"200":
@@ -3106,9 +3106,9 @@ definitions:
31063106
- Format: `users/{user.id}/models/{model.id}`.
31073107
The name of the tag.
31083108
- Format: `users/{user.id}/models/{model.id}/versions/{version.id}`.
3109-
id:
3109+
version:
31103110
type: string
3111-
description: The tag identifier.
3111+
description: The model version identifier, which is equal to image tag.
31123112
digest:
31133113
type: string
31143114
description: Unique identifier, computed from the manifest the tag refers to.

vdp/pipeline/v1beta/pipeline.proto

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1037,7 +1037,6 @@ message TriggerOrganizationPipelineResponse {
10371037
TriggerMetadata metadata = 2;
10381038
}
10391039

1040-
10411040
// TriggerOrganizationPipelineRequest represents a request to trigger an
10421041
// organization-owned pipeline synchronously.
10431042
message TriggerOrganizationPipelineStreamRequest {

0 commit comments

Comments
 (0)