Skip to content

Docker host mount prefix#3529

Merged
danielnelson merged 6 commits intomasterfrom
docker-host-mount-prefix
Dec 1, 2017
Merged

Docker host mount prefix#3529
danielnelson merged 6 commits intomasterfrom
docker-host-mount-prefix

Conversation

@danielnelson
Copy link
Contributor

Based on #2812, but only filters partitions if there is a conflict between the filesystem and the HOST_MOUNT_PREFIX, i.e.: /mnt/foo vs /hostfs/mnt/foo.

closes #1544
closes #2811
closes #3483

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

chadnickbok and others added 4 commits May 15, 2017 23:21
Change the behavior of "HOST_MOUNT_PREFIX" when listing out system
partition sizes. Previously, HOST_MOUNT_PREFIX was appended to every
partition found on the system. This meant that only partitions with
matching mount points between docker container and the host would be
successfully listed.

This appears to be an issue with assumptions about how upstream ps would
behave when listing partitions inside docker containers.
@danielnelson danielnelson added this to the 1.4.5 milestone Nov 30, 2017
@danielnelson
Copy link
Contributor Author

@m4ce @j-vizcaino @chadnickbok If you can review or test it would be appreciated.

@danielnelson danielnelson merged commit 7f66863 into master Dec 1, 2017
@danielnelson danielnelson deleted the docker-host-mount-prefix branch December 1, 2017 19:21
danielnelson added a commit that referenced this pull request Dec 1, 2017
aromeyer pushed a commit to aromeyer/telegraf that referenced this pull request May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Telegraf update broke [[inputs.disk]] functionality HOST_MOUNT_PREFIX not working as intended Disk input not reporting metrics for all mounted disk

2 participants