add librato output plugin, update datadog plugin#322
add librato output plugin, update datadog plugin#322jipperinbham wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
322c1c1 to
2fa0333
Compare
2fa0333 to
8df0c63
Compare
|
looks great, thanks much @jipperinbham 👍 |
There was a problem hiding this comment.
Go style tends to capitalize 3-letter acronyms. So this should be APIUser.
There was a problem hiding this comment.
good to know, I assume I'd need to annotate it with toml:"api_user" as well?
There was a problem hiding this comment.
apiUser would be more inline with what we would do in core.
There was a problem hiding this comment.
ok, my understanding was fields needed to be exported in order to be set properly from the toml config?
There was a problem hiding this comment.
I'm talking about the JSON encoding tag names. They can be lower case.
So be clear, the core team would write:
type Librato struct {
APIUser string `json:"apiUser"`
}
|
Some style suggestions, which would be more inline with how we code in Core. Not a big deal however. |
The following PR serves 2 purposes:
float64Also added READMEs for each output.