Skip to content

Commit 55f4e93

Browse files
authored
fix: regression: sort day by fileCreatedAt again (#18732)
* fix: regression: sort day by fileCreatedAt again * lint * e2e test * inline function * e2e * Address comments. Drop dayGroup and timezone in favor of localOffsetMinutes * lint and some api-doc * lint, more api-doc * format * Move minutes to fractional hours * make sql * merge/conflict * merge fallout, review comments * spelling * drop offset from returned date * move description into decorator where possible, regen api
1 parent 8142342 commit 55f4e93

File tree

23 files changed

+687
-247
lines changed

23 files changed

+687
-247
lines changed

e2e/src/api/specs/timeline.e2e-spec.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ describe('/timeline', () => {
7575
expect(status).toBe(200);
7676
expect(body).toEqual(
7777
expect.arrayContaining([
78-
{ count: 3, timeBucket: '1970-02-01T00:00:00.000Z' },
79-
{ count: 1, timeBucket: '1970-01-01T00:00:00.000Z' },
78+
{ count: 3, timeBucket: '1970-02-01' },
79+
{ count: 1, timeBucket: '1970-01-01' },
8080
]),
8181
);
8282
});
@@ -167,7 +167,8 @@ describe('/timeline', () => {
167167
isImage: [],
168168
isTrashed: [],
169169
livePhotoVideoId: [],
170-
localDateTime: [],
170+
fileCreatedAt: [],
171+
localOffsetHours: [],
171172
ownerId: [],
172173
projectionType: [],
173174
ratio: [],
@@ -204,7 +205,8 @@ describe('/timeline', () => {
204205
isImage: [],
205206
isTrashed: [],
206207
livePhotoVideoId: [],
207-
localDateTime: [],
208+
fileCreatedAt: [],
209+
localOffsetHours: [],
208210
ownerId: [],
209211
projectionType: [],
210212
ratio: [],

mobile/openapi/lib/api/timeline_api.dart

Lines changed: 42 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mobile/openapi/lib/model/asset_response_dto.dart

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mobile/openapi/lib/model/time_bucket_asset_response_dto.dart

Lines changed: 35 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mobile/openapi/lib/model/time_buckets_response_dto.dart

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)