resharper_possibly_impure_method_call_on_readonly_variable_highlighting=error

Author: ikpil

.editorconfig

@@ -24,3 +24,5 @@ csharp_preserve_single_line_blocks = true
 resharper_csharp_wrap_lines = false
 resharper_csharp_space_before_trailing_comment = true
 resharper_csharp_space_after_operator_keyword = true
+
+resharper_possibly_impure_method_call_on_readonly_variable_highlighting=error

src/Box2D.NET.Samples/Samples/Collisions/RayCast.cs

@@ -281,7 +281,7 @@ public override void Step()
             B2Vec2 translation = b2InvRotateVector(transform.q, b2Sub(m_rayEnd, m_rayStart));
             B2RayCastInput input = new B2RayCastInput(start, translation, maxFraction);
 
-            B2CastOutput localOutput = b2RayCastPolygon(m_box, input);
+            B2CastOutput localOutput = b2RayCastPolygon(ref m_box, input);
             if (localOutput.hit)
             {
                 output = localOutput;
@@ -302,7 +302,7 @@ public override void Step()
             B2Vec2 translation = b2InvRotateVector(transform.q, b2Sub(m_rayEnd, m_rayStart));
             B2RayCastInput input = new B2RayCastInput(start, translation, maxFraction);
 
-            B2CastOutput localOutput = b2RayCastPolygon(m_triangle, input);
+            B2CastOutput localOutput = b2RayCastPolygon(ref m_triangle, input);
             if (localOutput.hit)
             {
                 output = localOutput;

src/Box2D.NET/B2DynamicTrees.cs

@@ -1065,14 +1065,9 @@ internal static void b2DynamicTree_ValidateNoEnlarged(B2DynamicTree tree)
             B2TreeNode[] nodes = tree.nodes;
             for (int i = 0; i < capacity; ++i)
             {
-                ref B2TreeNode node = ref nodes[i];
+                ref readonly B2TreeNode node = ref nodes[i];
                 if (0 != (node.flags & (ushort)B2TreeNodeFlags.b2_allocatedNode))
                 {
-                    if ((node.flags & (ushort)B2TreeNodeFlags.b2_enlargedNode) != 0)
-                    {
-                        int a = 3;
-                    }
-
                     B2_ASSERT((node.flags & (ushort)B2TreeNodeFlags.b2_enlargedNode) == 0);
                 }
             }

src/Box2D.NET/B2Geometries.cs

@@ -840,7 +840,7 @@ public static B2CastOutput b2RayCastSegment(in B2Segment shape, in B2RayCastInpu
         }
 
         /// Ray cast versus polygon shape in local space.
-        public static B2CastOutput b2RayCastPolygon(in B2Polygon shape, in B2RayCastInput input)
+        public static B2CastOutput b2RayCastPolygon(ref B2Polygon shape, in B2RayCastInput input)
         {
             B2_ASSERT(b2IsValidRay(input));
 

src/Box2D.NET/B2Shapes.cs

@@ -852,7 +852,7 @@ internal static B2CastOutput b2RayCastShape(in B2RayCastInput input, B2Shape sha
                     output = b2RayCastCircle(shape.us.circle, localInput);
                     break;
                 case B2ShapeType.b2_polygonShape:
-                    output = b2RayCastPolygon(shape.us.polygon, localInput);
+                    output = b2RayCastPolygon(ref shape.us.polygon, localInput);
                     break;
                 case B2ShapeType.b2_segmentShape:
                     output = b2RayCastSegment(shape.us.segment, localInput, false);
@@ -1107,7 +1107,7 @@ internal static B2CastOutput b2Shape_RayCast(in B2ShapeId shapeId, in B2RayCastI
                     break;
 
                 case B2ShapeType.b2_polygonShape:
-                    output = b2RayCastPolygon(shape.us.polygon, localInput);
+                    output = b2RayCastPolygon(ref shape.us.polygon, localInput);
                     break;
 
                 case B2ShapeType.b2_chainSegmentShape:

test/Box2D.NET.Test/B2ShapeTest.cs

@@ -142,7 +142,7 @@ public void RayCastShapeTest()
         }
 
         {
-            B2CastOutput output = b2RayCastPolygon(box, input);
+            B2CastOutput output = b2RayCastPolygon(ref box, input);
             Assert.That(output.hit);
             Assert.That(output.normal.X + 1.0f, Is.LessThan(FLT_EPSILON));
             Assert.That(output.normal.Y, Is.LessThan(FLT_EPSILON));