Skip to content

feat: logs in api_retrieve_materials_blob() #9818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 1 commit into from
Oct 29, 2025
Merged

feat: logs in api_retrieve_materials_blob() #9818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ietf/meeting/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,7 @@ def _default_content_type(blob_name: str):
else:
# found the blob - return it
assert isinstance(blob, BlobFile)
log(f"Materials blob: directly returning {bucket}:{name}")
return FileResponse(
blob,
filename=name,
Expand All @@ -473,17 +474,20 @@ def _default_content_type(blob_name: str):
if doc.type_id != bucket:
raise Document.DoesNotExist
except Document.DoesNotExist:
log(f"Materials blob: no doc for {bucket}:{name}")
return HttpResponseNotFound(
f"Document corresponding to {bucket}:{name} not found."
)
else:
# create all missing blobs for the doc while we're at it
log(f"Materials blob: storing blobs for {doc.name}-{doc.rev}")
store_blobs_for_one_material_doc(doc)

# If we can make the blob at all, it now exists, so return it or a 404
try:
blob = storage.open(name, "rb")
except FileNotFoundError:
log(f"Materials blob: no blob for {bucket}:{name}")
return HttpResponseNotFound(f"Object {bucket}:{name} not found.")
else:
# found the blob - return it
Expand Down
Loading