Skip to content

Commit a86c62e

Browse files
fix: raw_id_fields for EventAdmin classes (#7711)
* fix: raw_id_fields for ReviewRequestDocEventAdmin * fix: raw_id_fields for ReviewAssignmentDocEventAdmin * fix: raw_id_fields for AddedMessageEventAdmin * fix: raw_id_fields for SubmissionDocEventAdmin * refactor: make inheritance clearer
1 parent 7b82e60 commit a86c62e

File tree

1 file changed

+27
-17
lines changed

1 file changed

+27
-17
lines changed

ietf/doc/admin.py

Lines changed: 27 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,13 @@ class DocumentActionHolderAdmin(admin.ModelAdmin):
142142

143143
# events
144144

145+
class DeletedEventAdmin(admin.ModelAdmin):
146+
list_display = ['id', 'content_type', 'json', 'by', 'time']
147+
list_filter = ['time']
148+
raw_id_fields = ['content_type', 'by']
149+
admin.site.register(DeletedEvent, DeletedEventAdmin)
150+
151+
145152
class DocEventAdmin(admin.ModelAdmin):
146153
def event_type(self, obj):
147154
return str(obj.type)
@@ -159,39 +166,42 @@ def short_desc(self, obj):
159166
admin.site.register(StateDocEvent, DocEventAdmin)
160167
admin.site.register(ConsensusDocEvent, DocEventAdmin)
161168
admin.site.register(BallotDocEvent, DocEventAdmin)
169+
admin.site.register(IRSGBallotDocEvent, DocEventAdmin)
162170
admin.site.register(WriteupDocEvent, DocEventAdmin)
163171
admin.site.register(LastCallDocEvent, DocEventAdmin)
164172
admin.site.register(TelechatDocEvent, DocEventAdmin)
165-
admin.site.register(ReviewRequestDocEvent, DocEventAdmin)
166-
admin.site.register(ReviewAssignmentDocEvent, DocEventAdmin)
167173
admin.site.register(InitialReviewDocEvent, DocEventAdmin)
168-
admin.site.register(AddedMessageEvent, DocEventAdmin)
169-
admin.site.register(SubmissionDocEvent, DocEventAdmin)
170174
admin.site.register(EditedAuthorsDocEvent, DocEventAdmin)
171175
admin.site.register(IanaExpertDocEvent, DocEventAdmin)
172176

173-
class DeletedEventAdmin(admin.ModelAdmin):
174-
list_display = ['id', 'content_type', 'json', 'by', 'time']
175-
list_filter = ['time']
176-
raw_id_fields = ['content_type', 'by']
177-
admin.site.register(DeletedEvent, DeletedEventAdmin)
178-
179177
class BallotPositionDocEventAdmin(DocEventAdmin):
180-
raw_id_fields = ["doc", "by", "balloter", "ballot"]
178+
raw_id_fields = DocEventAdmin.raw_id_fields + ["balloter", "ballot"]
181179
admin.site.register(BallotPositionDocEvent, BallotPositionDocEventAdmin)
182-
183-
class IRSGBallotDocEventAdmin(DocEventAdmin):
184-
raw_id_fields = ["doc", "by"]
185-
admin.site.register(IRSGBallotDocEvent, IRSGBallotDocEventAdmin)
186180

187181
class BofreqEditorDocEventAdmin(DocEventAdmin):
188-
raw_id_fields = ["doc", "by", "editors" ]
182+
raw_id_fields = DocEventAdmin.raw_id_fields + ["editors"]
189183
admin.site.register(BofreqEditorDocEvent, BofreqEditorDocEventAdmin)
190184

191185
class BofreqResponsibleDocEventAdmin(DocEventAdmin):
192-
raw_id_fields = ["doc", "by", "responsible" ]
186+
raw_id_fields = DocEventAdmin.raw_id_fields + ["responsible"]
193187
admin.site.register(BofreqResponsibleDocEvent, BofreqResponsibleDocEventAdmin)
194188

189+
class ReviewRequestDocEventAdmin(DocEventAdmin):
190+
raw_id_fields = DocEventAdmin.raw_id_fields + ["review_request"]
191+
admin.site.register(ReviewRequestDocEvent, ReviewRequestDocEventAdmin)
192+
193+
class ReviewAssignmentDocEventAdmin(DocEventAdmin):
194+
raw_id_fields = DocEventAdmin.raw_id_fields + ["review_assignment"]
195+
admin.site.register(ReviewAssignmentDocEvent, ReviewAssignmentDocEventAdmin)
196+
197+
class AddedMessageEventAdmin(DocEventAdmin):
198+
raw_id_fields = DocEventAdmin.raw_id_fields + ["message"]
199+
admin.site.register(AddedMessageEvent, AddedMessageEventAdmin)
200+
201+
class SubmissionDocEventAdmin(DocEventAdmin):
202+
raw_id_fields = DocEventAdmin.raw_id_fields + ["submission"]
203+
admin.site.register(SubmissionDocEvent, SubmissionDocEventAdmin)
204+
195205
class DocumentUrlAdmin(admin.ModelAdmin):
196206
list_display = ['id', 'doc', 'tag', 'url', 'desc', ]
197207
search_fields = ['doc__name', 'url', ]

0 commit comments

Comments
 (0)