Skip to content

Commit 3b07c70

Browse files
nouralmaanouralmaa
andauthored
feat: provide link to detailed submission status page for submission api (#10233)
* feat: include link to detailed submission status page for submission api * chore: rename endpoint to submission_url --------- Co-authored-by: nouralmaa <[email protected]>
1 parent c85ebbf commit 3b07c70

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

ietf/submit/tests.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2404,7 +2404,7 @@ def test_upload_draft(self):
24042404
response = r.json()
24052405
self.assertCountEqual(
24062406
response.keys(),
2407-
['id', 'name', 'rev', 'status_url'],
2407+
['id', 'name', 'rev', 'status_url', 'submission_url'],
24082408
)
24092409
submission_id = int(response['id'])
24102410
self.assertEqual(response['name'], 'draft-somebody-test')
@@ -2416,6 +2416,13 @@ def test_upload_draft(self):
24162416
kwargs={'submission_id': submission_id},
24172417
),
24182418
)
2419+
self.assertEqual(
2420+
response['submission_url'],
2421+
'https://datatracker.example.com' + urlreverse(
2422+
'ietf.submit.views.submission_status',
2423+
kwargs={'submission_id': submission_id},
2424+
)
2425+
)
24192426
self.assertEqual(mock_task.delay.call_count, 1)
24202427
self.assertEqual(mock_task.delay.call_args.args, (submission_id,))
24212428
submission = Submission.objects.get(pk=submission_id)

ietf/submit/views.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,10 @@ def err(code, error, messages=None):
182182
settings.IDTRACKER_BASE_URL,
183183
urlreverse(api_submission_status, kwargs={'submission_id': submission.pk}),
184184
),
185+
'submission_url': urljoin(
186+
settings.IDTRACKER_BASE_URL,
187+
urlreverse("ietf.submit.views.submission_status", kwargs={'submission_id': submission.pk}),
188+
),
185189
}
186190
)
187191
else:

0 commit comments

Comments
 (0)