feat: add liaison coordinators, remove from restrictions (#9055)

* refactor: clean up outgoing LS from field init

* feat: additional LS "from" groups for IETF/IAB Chair+ADs

* refactor: reduce queries in get_internal_choices

* refactor: break down / rename get_groups_for_person

* refactor: inline / remove unneeded methods

* refactor: colocate similar field config

* refactor: unify role logic for LS To fields

* fix: typo

* refactor: update EditLiaisonForm to match changes

* refactor: update IncomingLiaisonForm to match

* fix: typo / add docstring

* test: framing for new tests; test_flatten_choices()

* test: test_choices_from_group_queryset()

* test: test_all_internal_groups()

* fix: no person = no internal groups for LS

* test: test_all_internal_groups()

* test: test_external_groups_for_person()

* chore: adjust iab execdir and sdo auth'd individs

Need to confirm what is actually needed, but without
these users may be able to create/edit LS's they can't
actually fill in.

* fix: f-string flakes

* fix: remove authorized persons from sdo groups

* fix: remove liaison_contact and liaison_cc_contact Role objects

* feat: liaison coordinators (#8944)

* feat: liaison coordinators

* fix: give liaison coordinator the ability to send incoming

* feat: more flexible liaison stmt "From Contact" (#8958)

* refactor: CharField for LS from_contacts

* refactor: replace from_contact field

* style: copyrights + ruff

* fix: listify in the right place

* refactor: better validator

* refactor: use new from_contact field; fix lint

* fix: cleanup

* feat: default addresses for roles

* chore: update liaisons.resources

from_name and to_name were removed in 2015!

* fix: improve managing liaison coordinators (#8960)

* fix: align liaison coordinator perms with secretariat perms

---------

Co-authored-by: Jennifer Richards <[email protected]>

Author: rjsparks

ietf/group/migrations/0005_remove_sdo_authorized_individuals.py

@@ -0,0 +1,49 @@
+# Copyright The IETF Trust 2025, All Rights Reserved
+
+from django.db import migrations
+
+
+def forward(apps, schema_editor):
+    Group = apps.get_model("group", "Group")
+    GroupFeatures = apps.get_model("group", "GroupFeatures")
+    iab = Group.objects.get(acronym="iab")
+    iab.used_roles = [
+        "chair",
+        "delegate",
+        "exofficio",
+        "liaison",
+        "liaison_coordinator",
+        "member",
+    ]
+    iab.save()
+    GroupFeatures.objects.filter(type_id="ietf").update(
+        default_used_roles=[
+            "ad",
+            "member",
+            "comdir",
+            "delegate",
+            "execdir",
+            "recman",
+            "secr",
+            "chair",
+        ]
+    )
+
+
+def reverse(apps, schema_editor):
+    Group = apps.get_model("group", "Group")
+    iab = Group.objects.get(acronym="iab")
+    iab.used_roles = []
+    iab.save()
+    # Intentionally not putting trac-* back into grouptype ietf default_used_roles
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("group", "0006_remove_liason_contacts"),
+        ("name", "0018_alter_rolenames"),
+    ]
+
+    operations = [
+        migrations.RunPython(forward, reverse),
+    ]

ietf/group/migrations/0006_remove_liason_contacts.py

@@ -137,6 +137,10 @@ def has_role(user, role_names, *args, **kwargs):
                 group__type="sdo",
                 group__state="active",
             ),
+            "Liaison Coordinator": Q(
+                name="liaison_coordinator",
+                group__acronym="iab",
+            ),
             "Authorized Individual": Q(
                 name="auth",
                 group__type="sdo",

ietf/group/migrations/0007_used_roles.py

@@ -24,7 +24,7 @@ class LiaisonStatementAdmin(admin.ModelAdmin):
     list_display = ['id', 'title', 'submitted', 'from_groups_short_display', 'purpose', 'related_to']
     list_display_links = ['id', 'title']
     ordering = ('title', )
-    raw_id_fields = ('from_contact', 'attachments', 'from_groups', 'to_groups')
+    raw_id_fields = ('attachments', 'from_groups', 'to_groups')
     #filter_horizontal = ('from_groups', 'to_groups')
     inlines = [ RelatedLiaisonStatementInline, LiaisonStatementAttachmentInline ]
 
@@ -50,4 +50,4 @@ class LiaisonStatementEventAdmin(admin.ModelAdmin):
     raw_id_fields = ["statement", "by"]
 
 admin.site.register(LiaisonStatement, LiaisonStatementAdmin)
-admin.site.register(LiaisonStatementEvent, LiaisonStatementEventAdmin)
+admin.site.register(LiaisonStatementEvent, LiaisonStatementEventAdmin)

ietf/ietfauth/utils.py

@@ -9,7 +9,7 @@ class Meta:
         skip_postgeneration_save = True
 
     title = factory.Faker('sentence')
-    from_contact = factory.SubFactory('ietf.person.factories.EmailFactory')
+    from_contact = factory.Faker('email')
     purpose_id = 'comment'
     body = factory.Faker('paragraph')
     state_id = 'posted'