Skip to content
This repository was archived by the owner on Oct 16, 2021. It is now read-only.

Commit 6cd82cd

Browse files
trevnorrisjBarz
authored andcommitted
node: fix leaking Context handle
The call to node::Environment::GetCurrent(Isolate*) makes the call to v8::Isolate::GetCurrentContext(). Doing so creates a new handle that bubbled to the v8::SealHandleScope(). PR-URL: nodejs/node#3945 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James Snell <[email protected]>
1 parent b5571c6 commit 6cd82cd

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/node.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3177,6 +3177,7 @@ static void EnableDebug(Environment* env) {
31773177

31783178
// Called from the main thread.
31793179
static void DispatchDebugMessagesAsyncCallback(uv_async_t* handle) {
3180+
HandleScope scope(node_isolate);
31803181
if (debugger_running == false) {
31813182
fprintf(stderr, "Starting debugger agent.\n");
31823183

0 commit comments

Comments
 (0)