fix: emit explicit CAST for float literals in SQL compilation#11982
Closed
joaquinhuigomez wants to merge 1 commit into
Closed
fix: emit explicit CAST for float literals in SQL compilation#11982joaquinhuigomez wants to merge 1 commit into
joaquinhuigomez wants to merge 1 commit into
Conversation
Float literals like 0.5518 were compiled without a CAST, causing Postgres to interpret them as numeric/decimal instead of double precision. Closes ibis-project#11947
github-actions
Bot
added
tests
Author
|
Realized this needs more thorough testing against additional backends before submitting. Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Float literals were compiled without an explicit CAST, causing Postgres to interpret values like
0.5518asnumeric/decimalinstead ofdouble precision. Integer literals already received the correct CAST.Adds a
dtype.is_floating()check in the Postgres compiler'svisit_NonNullLiteralthat wraps finite float values inCAST(... AS DOUBLE PRECISION), matching the existing behavior for other typed literals.Non-finite values (NaN, inf) are left to the base class handler which already produces the correct
'NaN'::DOUBLE PRECISIONetc.Closes #11947