Skip to content

refactor: rename to_sqlglot to to_sqlglot_columns_definition #11455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2025
Merged

refactor: rename to_sqlglot to to_sqlglot_columns_definition #11455

merged 2 commits into from
Jul 24, 2025

Conversation

IndexSeek
Copy link
Member

Description of changes

I renamed the to_sqlglot method to to_sqlglot_columns_definition and updated backend implementations to use the new name. I also added a test for this as I did not see one for to_sqlglot.

I deprecated the old with the note that we will likely still keep it and change to be a SQLGlot schema, but wanted to be sure that was the intention.

Issues closed

Closes #11310

@github-actions github-actions bot added tests Issues or PRs related to tests impala The Apache Impala backend postgres The PostgreSQL backend sqlite The SQLite backend clickhouse The ClickHouse backend mysql The MySQL backend datafusion The Apache DataFusion backend bigquery The BigQuery backend duckdb The DuckDB backend snowflake The Snowflake backend mssql The Microsoft SQL Server backend trino The Trino backend oracle The Oracle backend exasol Issues related to the exasol backend risingwave The RisingWave backend databricks The Databricks backend athena The Amazon Athena backend labels Jul 12, 2025
@IndexSeek IndexSeek requested a review from cpcloud July 12, 2025 17:34
cpcloud
cpcloud approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a name change suggestion.

@IndexSeek IndexSeek force-pushed the rename-to_sqlglot branch from 3e1ba88 to f0bbe91 Compare July 16, 2025 22:08
@cpcloud cpcloud merged commit 0e4cf43 into ibis-project:main Jul 24, 2025
179 of 192 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
athena The Amazon Athena backend bigquery The BigQuery backend clickhouse The ClickHouse backend databricks The Databricks backend datafusion The Apache DataFusion backend duckdb The DuckDB backend exasol Issues related to the exasol backend impala The Apache Impala backend mssql The Microsoft SQL Server backend mysql The MySQL backend oracle The Oracle backend postgres The PostgreSQL backend risingwave The RisingWave backend snowflake The Snowflake backend sqlite The SQLite backend tests Issues or PRs related to tests trino The Trino backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Schema.from_sqlglot()
2 participants
@IndexSeek @cpcloud