fix(duckdb/snowflake): decouple Pandas and PyArrow backend converters #11431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
duckdb
DuckDB and Snowflake are backends that have both Pandas and PyArrow converters. Catching their import errors allows each to be used without the other dependency. The behavior will remain same - whether installed or not - because the upstream imports of PandasData and PyArrowData are already lazy. fixes ibis-project#11430, refs ibis-project#10166
|
Trino is broken right now due to a change I merged a bit too hastily, so no need to worry about that. Otherwise, LGTM! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
DuckDB and Snowflake are backends that have both Pandas and PyArrow converters. Catching their import errors allows each to be used without the other dependency. The behavior will remain same - whether installed or not - because the upstream imports of PandasData and PyArrowData are already lazy.
Issues closed
fixes #11430, refs #10166