Skip to content

fix(psycopg): avoid specifying the psycopg dependency implementation #11424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

fix(psycopg): avoid specifying the psycopg dependency implementation #11424

merged 2 commits into from
Jul 3, 2025

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 3, 2025 •
edited
Loading

Closes #11423.

@github-actions github-actions bot added ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies nix Issues or PRs related to nix labels Jul 3, 2025
@cpcloud cpcloud mentioned this pull request Jul 3, 2025
Closed
@cpcloud cpcloud changed the title fix(psycopg): avoid specifying the interface fix(psycopg): avoid specifying the dependency library implementation Jul 3, 2025
@cpcloud cpcloud changed the title fix(psycopg): avoid specifying the dependency library implementation fix(psycopg): avoid specifying the psycopg dependency implementation Jul 3, 2025
@tjstum
Copy link

tjstum commented Jul 3, 2025

Thanks!

You might want to take psycopg-c in your requirements-dev.txt, but I'm not entirely confident on that.

@cpcloud
Copy link
Member Author

cpcloud commented Jul 3, 2025

Our requirements-dev.txt is automatically generated, so that there's a single source of truth for everything--pyproject.toml and nothing gets out of sync.

psycopg unqualified uses a pure python interface if nothing is specified, which suffices for ibis's purpose, mainly testing.

@cpcloud cpcloud merged commit 038c339 into ibis-project:main Jul 3, 2025
106 of 108 checks passed
@cpcloud cpcloud deleted the psycopg-fix branch July 3, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Continuous Integration issues or PRs dependencies Issues or PRs related to dependencies nix Issues or PRs related to nix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

psycopg dependency group shouldn't include an implementation
2 participants
@cpcloud @tjstum