Skip to content

Conversation

NickCrews
Copy link
Contributor

Fixes #11391

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor style suggestions.

@cpcloud cpcloud merged commit 6521a53 into ibis-project:main Jun 27, 2025
102 of 109 checks passed
@KronosTheLate
Copy link

That looks very precise and clear, thanks for the effort!

@KronosTheLate
Copy link

I should have mentioned this earlier, but just came to think of it:

Would it not be more clear to name the distinct argument multiset instead?

@NickCrews
Copy link
Contributor Author

I think I actually prefer prefer distinct over multiset, to be difficult :). But I don't love distinct either. To me it makes good sense for union(), some amount of sense for intersection(), but not much sense for difference(). If you have other ideas throw them out there.

I think whatever name we go with, it must be the same in all of difference(), union(), and intersection().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: More examples for intersect and duplicate values
3 participants