Skip to content

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 5, 2025

Seems like this is unused. We go through the backend via a module-level __getattr__ now, and have been for a while.

@cpcloud
Copy link
Member Author

cpcloud commented Jun 10, 2025

BigQuery tests are passing with this PR:

…/ibis on  remove-bigquery-connect is 📦 v10.5.0 via 🐍 v3.13.3 via ❄️  impure (ibis-3.13-env) took 6s
❯ pytest -m bigquery -n auto --dist loadgroup -q -x
bringing up nodes...
.................xxsssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss............s....xx.....x......s...................................s.x.. [  8%]
........x........xx.x..xsssssssssssssssssssss..xx..x.x.xxx...xx.x.x...x........xx........xx.xx.....x........x.x.......x......x............x...x..x.......x...x......x..x.............x.x...... [ 16%]
............x.....x......x....x.............x...xx............x.....x.......................x.x.......................x.....x.....................x.....x................x.x........x......... [ 24%]
.x..............x.........................x..x..x.......x................x....x...xx.......x....x.x.......x......x....x...................x.....x......x.........s...x........x..s.x.......... [ 32%]
......x..s.s.xx.....x.x...........x................xx.........x...................x........x.....x........x..........x.......x...........................x......x..x..xx...........xx......xx. [ 41%]
.x.....x.xx.........x.x...xx......x.....x....x...x..x......x..xx..X....x..xX.....x.x.x.............x.........x.X.x.......x.....x............x.xxx....x..xx.........x....x.Xxx............x.... [ 49%]
.xxxx.x....x.xx..x..xxxxxx.xxxxxx.xxxxx.xx.xxxxxx.xxxxx.xxxxxxxxxxxxxxx.x.xxx.xxxxxxxxxxxxxxxxxx.xxxxxxxxxxxxxxxxx.xxxxx..xxxxxxxxxxxxxxxxx.x.xxx.x..x.x.x..x...................s.x.x..x..x... [ 57%]
x.x...x......x....xxxxx.......x.xx....xx...x...x...x....x...xx..x....x..x...x......x.....x..........xx...xx...x..x.....x...x..x..xx...x..xx.x..............x..xx...xxxx......xxx........x..x.. [ 65%]
xxx.........x..xx.x...xx...........x..............xx.x..........xx...x..............x...........xx......x.................xx..............xx.................................................. [ 74%]
...x.............................x..................x...................x..................................................................................................................... [ 82%]
.....................ss................s........s.......................................................x...................x..................x.............................................. [ 90%]
........................................................................................................................x..................................................................... [ 98%]
........................                                                                                                     [100%]
1810 passed, 132 skipped, 358 xfailed, 4 xpassed in 439.61s (0:07:19)

@cpcloud cpcloud force-pushed the remove-bigquery-connect branch from 03cb6a5 to 4f59667 Compare June 10, 2025 12:53
@cpcloud cpcloud merged commit 77a6dff into ibis-project:main Jun 10, 2025
104 of 107 checks passed
@cpcloud cpcloud deleted the remove-bigquery-connect branch June 10, 2025 12:53
@github-actions github-actions bot added the bigquery The BigQuery backend label Jun 10, 2025
@jeandsantos
Copy link

@cpcloud I actually use the ibis.backends.bigquery.connect() function. Would it be possible to have a DeprecationWarning raised next time such functions/methods are removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery The BigQuery backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants