feat(backends): fixup drop_database() when passing a specific catalog #11110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
NickCrews
force-pushed
the
duckdb-drop-db-current-catalog
branch
from
62c3228 to
7314923
Compare
cpcloud
force-pushed
the
duckdb-drop-db-current-catalog
branch
2 times, most recently
from
e353ee7 to
c8cbd8c
Compare
NickCrews
force-pushed
the
duckdb-drop-db-current-catalog
branch
from
c8cbd8c to
4be515d
Compare
github-actions
bot
added
postgres
NickCrews
changed the title
|
@cpcloud Any idea why the pyspark CI is failing? It looks sort of related to this PR, but only indirectly. eg I am wondering if we are stumbling across a dependency between tests, where one test initializes the catalog, and that needs to run before another test. eg possibly this stackoverflow answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started with fixing duckdb to support
.drop_database("mydb", catalog=self.current_catalog), but then when I added a test it revealed that many backends didn't implement this correctly.