feat(postgres): add support for reading enum types as strings #11028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCrews
force-pushed
the
postgres-read-enum
branch
from
0b0ff19 to
8c5a8df
Compare
NickCrews
force-pushed
the
postgres-read-enum
branch
3 times, most recently
from
6298694 to
3f796c7
Compare
NickCrews
force-pushed
the
postgres-read-enum
branch
from
3f796c7 to
4cd121f
Compare
cpcloud
approved these changes
Mar 23, 2025
|
Thanks! |
|
I am discovering now that this PR did NOT generalize postgres to work for nested types that contain enums, eg an enum array column. So that would need to be done in a followup PR if anyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to, but not a full implementation, for #10991.
Just curious @cpcloud, is there a reason why we build up these schema queries using sqlglot instead of just raw SQL? Since we know this will only ever run on postgres, the portability/translation benefits of sqlglot are wasted. It seems like just writing the raw SQL string will be faster to execute, more stable, more familiar to more maintainers, and is easier to edit with LLMs (what I did here was compile this to SQL, ask an LLM to adjust it, and then translated the response back to sqlglot).