chore: support python 3.9

cpcloud · cpcloud · commit d2555198b59d · 2025-03-07T08:06:38.000-05:00
diff --git a/.github/workflows/ibis-backends-cloud.yml b/.github/workflows/ibis-backends-cloud.yml
@@ -37,7 +37,7 @@ jobs:
         os:
           - ubuntu-latest
         python-version:
-          - "3.10"
+          - "3.9"
           - "3.13"
         backend:
           - name: snowflake
@@ -54,7 +54,7 @@ jobs:
               - --extra athena
         include:
           - os: ubuntu-latest
-            python-version: "3.10"
+          - python-version: "3.9"
             backend:
               name: bigquery
               title: BigQuery
diff --git a/.github/workflows/ibis-backends.yml b/.github/workflows/ibis-backends.yml
@@ -52,7 +52,7 @@ jobs:
           - ubuntu-latest
           - windows-latest
         python-version:
-          - "3.10"
+          - "3.9"
           - "3.13"
     steps:
       - name: checkout
@@ -92,7 +92,7 @@ jobs:
           - ubuntu-latest
           - windows-latest
         python-version:
-          - "3.10"
+          - "3.9"
           - "3.13"
         backend:
           - name: duckdb
@@ -547,7 +547,7 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - python-version: "3.10"
+          - python-version: "3.9"
             pyspark-minor-version: "3.3"
             tag: local
             deps:
diff --git a/.github/workflows/ibis-main.yml b/.github/workflows/ibis-main.yml
@@ -46,6 +46,7 @@ jobs:
           - ubuntu-latest
           - windows-latest
         python-version:
+          - "3.9"
           - "3.10"
           - "3.11"
           - "3.12"
diff --git a/.github/workflows/nix-skip-helper.yml b/.github/workflows/nix-skip-helper.yml
@@ -41,7 +41,7 @@ jobs:
           - "3.13"
         include:
           - os: ubuntu-latest
-            python-version: "3.10"
+            python-version: "3.9"
           - os: ubuntu-latest
             python-version: "3.11"
     steps:
diff --git a/.github/workflows/nix.yml b/.github/workflows/nix.yml
@@ -43,7 +43,7 @@ jobs:
           - "3.13"
         include:
           - os: ubuntu-latest
-            python-version: "3.10"
+            python-version: "3.9"
           - os: ubuntu-latest
             python-version: "3.11"
     steps:
diff --git a/flake.nix b/flake.nix
@@ -163,18 +163,20 @@
         packages = {
           default = packages.ibis313;
 
-          inherit (pkgs) ibis310 ibis311 ibis312 ibis313
+          inherit (pkgs) ibis39 ibis310 ibis311 ibis312 ibis313
             update-lock-files check-release-notes-spelling;
         };
 
         checks = {
+          ibis39-pytest = pkgs.ibis39.passthru.tests.pytest;
           ibis310-pytest = pkgs.ibis310.passthru.tests.pytest;
           ibis311-pytest = pkgs.ibis311.passthru.tests.pytest;
           ibis312-pytest = pkgs.ibis312.passthru.tests.pytest;
           ibis313-pytest = pkgs.ibis313.passthru.tests.pytest;
         };
 
         devShells = rec {
+          ibis39 = mkDevShell pkgs.ibisDevEnv39;
           ibis310 = mkDevShell pkgs.ibisDevEnv310;
           ibis311 = mkDevShell pkgs.ibisDevEnv311;
           ibis312 = mkDevShell pkgs.ibisDevEnv312;
diff --git a/ibis/backends/__init__.py b/ibis/backends/__init__.py
@@ -1528,7 +1528,10 @@ def _get_backend_names(*, exclude: tuple[str] = ()) -> frozenset[str]:
 
     """
 
-    entrypoints = importlib.metadata.entry_points(group="ibis.backends")
+    if sys.version_info < (3, 10):
+        entrypoints = importlib.metadata.entry_points()["ibis.backends"]
+    else:
+        entrypoints = importlib.metadata.entry_points(group="ibis.backends")
     return frozenset(ep.name for ep in entrypoints).difference(exclude)
 
 
diff --git a/ibis/backends/postgres/tests/test_udf.py b/ibis/backends/postgres/tests/test_udf.py
@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import functools
+import sys
 
 import pytest
 
@@ -118,6 +119,11 @@ def mult_a_b(a: int, b: int) -> int:
     assert result["mult_result"].iat[0] == 8
 
 
+@pytest.mark.xfail(
+    condition=sys.version_info[:2] < (3, 9),
+    raises=TypeError,
+    reason="no straightforward way to use new (Python 3.9) annotations syntax",
+)
 def test_array_type(test_database, table):
     """Test that usage of Array types work Other scalar types can be
     represented either by the class or an instance, but Array types work
diff --git a/ibis/backends/sql/compilers/base.py b/ibis/backends/sql/compilers/base.py
@@ -7,7 +7,7 @@
 import operator
 import string
 from functools import partial, reduce
-from typing import TYPE_CHECKING, Any, ClassVar
+from typing import TYPE_CHECKING, Any, Callable, ClassVar
 
 import sqlglot as sg
 import sqlglot.expressions as sge
@@ -51,7 +51,7 @@ def AlterTable(*args, kind="TABLE", **kwargs):
 
 
 if TYPE_CHECKING:
-    from collections.abc import Callable, Iterable, Mapping
+    from collections.abc import Iterable, Mapping
 
     import ibis.expr.schema as sch
     import ibis.expr.types as ir
diff --git a/ibis/backends/sql/compilers/bigquery/udf/core.py b/ibis/backends/sql/compilers/bigquery/udf/core.py
@@ -9,14 +9,11 @@
 import textwrap
 from collections import ChainMap
 from inspect import _empty as EMPTY
-from typing import TYPE_CHECKING
+from typing import Callable
 
 from ibis.backends.sql.compilers.bigquery.udf.find import find_names
 from ibis.backends.sql.compilers.bigquery.udf.rewrite import rewrite
 
-if TYPE_CHECKING:
-    from collections.abc import Callable
-
 
 class SymbolTable(ChainMap):
     """ChainMap subclass implementing scope for the translator.
diff --git a/ibis/backends/sqlite/udf.py b/ibis/backends/sqlite/udf.py
@@ -6,13 +6,10 @@
 import operator
 from collections import defaultdict
 from datetime import date
-from typing import TYPE_CHECKING, Any, NamedTuple
+from typing import Any, Callable, NamedTuple
 from urllib.parse import parse_qs, urlsplit
 from uuid import uuid4
 
-if TYPE_CHECKING:
-    from collections.abc import Callable
-
 try:
     import regex as re
 except ImportError:
diff --git a/ibis/backends/tests/test_udf.py b/ibis/backends/tests/test_udf.py
@@ -63,6 +63,11 @@ def num_vowels(s: str, include_y: bool = False) -> int:
     ["postgres"], raises=TypeError, reason="postgres only supports map<string, string>"
 )
 @mark.notimpl(["polars"])
+@mark.never(
+    ["flink"],
+    condition=sys.version_info < (3, 10),
+    reason="broken with Python 3.9; works in Python 3.10",
+)
 @mark.notyet(["datafusion"], raises=NotImplementedError)
 @mark.notyet(
     ["sqlite"], raises=com.IbisTypeError, reason="sqlite doesn't support map types"
@@ -92,6 +97,11 @@ def num_vowels_map(s: str, include_y: bool = False) -> dict[str, int]:
     ["postgres"], raises=TypeError, reason="postgres only supports map<string, string>"
 )
 @mark.notimpl(["polars"])
+@mark.never(
+    ["flink"],
+    condition=sys.version_info < (3, 10),
+    reason="broken with Python 3.9; works in Python 3.10",
+)
 @mark.notyet(["datafusion"], raises=NotImplementedError)
 @mark.notyet(["sqlite"], raises=TypeError, reason="sqlite doesn't support map types")
 def test_map_merge_udf(batting):
diff --git a/ibis/common/annotations.py b/ibis/common/annotations.py
@@ -3,7 +3,7 @@
 import functools
 import inspect
 import types
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Callable
 from typing import Any as AnyType
 
 from typing_extensions import Self
@@ -21,7 +21,7 @@
 from ibis.common.typing import format_typehint, get_type_hints
 
 if TYPE_CHECKING:
-    from collections.abc import Callable, Sequence
+    from collections.abc import Sequence
 
 EMPTY = inspect.Parameter.empty  # marker for missing argument
 KEYWORD_ONLY = inspect.Parameter.KEYWORD_ONLY
diff --git a/ibis/common/caching.py b/ibis/common/caching.py
@@ -1,10 +1,7 @@
 from __future__ import annotations
 
 import functools
-from typing import TYPE_CHECKING
-
-if TYPE_CHECKING:
-    from collections.abc import Callable
+from typing import Callable
 
 
 def memoize(func: Callable) -> Callable:
diff --git a/ibis/common/deferred.py b/ibis/common/deferred.py
@@ -5,8 +5,7 @@
 import inspect
 import operator
 from abc import abstractmethod
-from collections.abc import Callable
-from typing import Any, TypeVar, overload
+from typing import Any, Callable, TypeVar, overload
 
 from ibis.common.bases import Final, FrozenSlotted, Hashable, Immutable, Slotted
 from ibis.common.collections import FrozenDict
diff --git a/ibis/common/dispatch.py b/ibis/common/dispatch.py
@@ -3,14 +3,9 @@
 import abc
 import functools
 from collections import defaultdict
-from types import UnionType
 from typing import Union
 
-from ibis.common.typing import (
-    evaluate_annotations,
-    get_args,
-    get_origin,
-)
+from ibis.common.typing import UnionType, evaluate_annotations, get_args, get_origin
 from ibis.util import import_object, unalias_package
 
 
diff --git a/ibis/common/exceptions.py b/ibis/common/exceptions.py
@@ -15,10 +15,7 @@
 
 from __future__ import annotations
 
-from typing import TYPE_CHECKING, Any
-
-if TYPE_CHECKING:
-    from collections.abc import Callable
+from typing import Any, Callable
 
 
 class TableNotFound(Exception):
diff --git a/ibis/common/graph.py b/ibis/common/graph.py
@@ -5,8 +5,8 @@
 import itertools
 from abc import abstractmethod
 from collections import deque
-from collections.abc import Callable, Iterable, Iterator, KeysView, Mapping, Sequence
-from typing import TYPE_CHECKING, Any, Optional, TypeVar, Union
+from collections.abc import Iterable, Iterator, KeysView, Mapping, Sequence
+from typing import TYPE_CHECKING, Any, Callable, Optional, TypeVar, Union
 
 from ibis.common.bases import Hashable
 from ibis.common.patterns import NoMatch, Pattern
@@ -22,7 +22,7 @@
 Finder = Callable[["Node"], bool]
 FinderLike = Union[Finder, Pattern, _ClassInfo]
 
-Replacer = Callable[["Node", dict["Node", Any] | None], "Node"]
+Replacer = Callable[["Node", Optional[dict["Node", Any]]], "Node"]
 ReplacerLike = Union[Replacer, Pattern, Mapping]
 
 
diff --git a/ibis/common/patterns.py b/ibis/common/patterns.py
@@ -14,13 +14,11 @@
     Optional,
     TypeVar,
     Union,
-    get_args,
-    get_origin,
 )
 from typing import Any as AnyType
 
 import toolz
-from typing_extensions import GenericMeta
+from typing_extensions import GenericMeta, get_args, get_origin
 
 from ibis.common.bases import FrozenSlotted as Slotted
 from ibis.common.bases import Hashable, Singleton
diff --git a/ibis/common/tests/conftest.py b/ibis/common/tests/conftest.py
@@ -1,3 +1,7 @@
 from __future__ import annotations
 
+import sys
+
 collect_ignore: list[str] = []
+if sys.version_info < (3, 10):
+    collect_ignore.append("test_grounds_py310.py")
diff --git a/ibis/common/tests/test_grounds.py b/ibis/common/tests/test_grounds.py
@@ -5,8 +5,7 @@
 import sys
 import weakref
 from abc import ABCMeta
-from collections.abc import Callable
-from typing import TYPE_CHECKING, Generic, Optional, TypeVar, Union
+from typing import TYPE_CHECKING, Callable, Generic, Optional, TypeVar, Union
 
 import pytest
 
diff --git a/ibis/common/typing.py b/ibis/common/typing.py
@@ -5,7 +5,7 @@
 import sys
 from abc import abstractmethod
 from itertools import zip_longest
-from typing import TYPE_CHECKING, Any, Optional, TypeVar, get_args, get_origin
+from typing import TYPE_CHECKING, Any, Optional, TypeVar, Union, get_args, get_origin
 from typing import get_type_hints as _get_type_hints
 
 from ibis.common.bases import Abstract
@@ -14,11 +14,18 @@
 if TYPE_CHECKING:
     from typing_extensions import Self
 
-from types import UnionType
-from typing import TypeAlias
 
-# Keep this alias in sync with unittest.case._ClassInfo
-_ClassInfo: TypeAlias = type | UnionType | tuple["_ClassInfo", ...]
+if sys.version_info >= (3, 10):
+    from types import UnionType
+    from typing import TypeAlias
+
+    # Keep this alias in sync with unittest.case._ClassInfo
+    _ClassInfo: TypeAlias = type | UnionType | tuple["_ClassInfo", ...]
+else:
+    from typing_extensions import TypeAlias
+
+    UnionType = object()
+    _ClassInfo: TypeAlias = Union[type, tuple["_ClassInfo", ...]]
 
 
 T = TypeVar("T")
diff --git a/ibis/config.py b/ibis/config.py
@@ -1,7 +1,6 @@
 from __future__ import annotations
 
-from collections.abc import Callable  # noqa: TC003
-from typing import Annotated, Any, Optional
+from typing import Annotated, Any, Callable, Optional
 
 from public import public
 
diff --git a/ibis/expr/datatypes/core.py b/ibis/expr/datatypes/core.py
@@ -15,14 +15,12 @@
     NamedTuple,
     Optional,
     TypeVar,
-    get_args,
-    get_origin,
     get_type_hints,
 )
 
 import toolz
 from public import public
-from typing_extensions import Self
+from typing_extensions import Self, get_args, get_origin
 
 from ibis.common.annotations import attribute
 from ibis.common.collections import FrozenOrderedDict, MapSet
@@ -913,7 +911,7 @@ class Array(Variadic, Parametric, Generic[T]):
 
     value_type: T
     """Element type of the array."""
-    length: Annotated[int, Between(lower=0)] | None = None
+    length: Optional[Annotated[int, Between(lower=0)]] = None
     """The length of the array if known."""
 
     scalar = "ArrayScalar"
diff --git a/ibis/expr/operations/tests/conftest.py b/ibis/expr/operations/tests/conftest.py
@@ -1,3 +1,7 @@
 from __future__ import annotations
 
+import sys
+
 collect_ignore: list[str] = []
+if sys.version_info < (3, 10):
+    collect_ignore.append("test_core_py310.py")
diff --git a/ibis/expr/operations/udf.py b/ibis/expr/operations/udf.py
diff --git a/ibis/expr/schema.py b/ibis/expr/schema.py
diff --git a/ibis/expr/types/arrays.py b/ibis/expr/types/arrays.py
diff --git a/ibis/expr/types/relations.py b/ibis/expr/types/relations.py
diff --git a/ibis/expr/types/temporal_windows.py b/ibis/expr/types/temporal_windows.py
diff --git a/ibis/expr/visualize.py b/ibis/expr/visualize.py
diff --git a/ibis/legacy/udf/validate.py b/ibis/legacy/udf/validate.py
diff --git a/ibis/selectors.py b/ibis/selectors.py
diff --git a/ibis/tests/util.py b/ibis/tests/util.py
diff --git a/ibis/util.py b/ibis/util.py
diff --git a/nix/overlay.nix b/nix/overlay.nix
