fix(athena): only replace commas instead of all special characters in column names

Author: cpcloud

ibis/backends/sql/compilers/athena.py

@@ -8,7 +8,7 @@
 from ibis.backends.sql.compilers.trino import TrinoCompiler
 from ibis.backends.sql.datatypes import AthenaType
 
-_NAME_REGEX = re.compile(r'[^!"$()*,./;?@[\\\]^`{}~\n]+')
+_COMMA_REGEX = re.compile(r"[^,]+")
 
 
 class AthenaCompiler(TrinoCompiler):
@@ -34,7 +34,7 @@ class AthenaCompiler(TrinoCompiler):
 
     @staticmethod
     def _gen_valid_name(name: str) -> str:
-        return "_".join(map(str.strip, _NAME_REGEX.findall(name))) or "tmp"
+        return ";".join(map(str.strip, _COMMA_REGEX.findall(name))) or "tmp"
 
 
 compiler = AthenaCompiler()

ibis/backends/tests/snapshots/test_sql/test_isin_bug/athena/out.sql

@@ -5,5 +5,5 @@ SELECT
     FROM "t" AS "t0"
     WHERE
       "t0"."x" > 2
-  ) AS "InSubquery_x"
+  ) AS "InSubquery(x)"
 FROM "t" AS "t0"

ibis/backends/tests/snapshots/test_sql/test_to_sql_default_backend/athena/to_sql.sql

@@ -1,5 +1,5 @@
 SELECT
-  COUNT(*) AS "CountStar"
+  COUNT(*) AS "CountStar()"
 FROM (
   SELECT
     *