Making mshv3 the default mshv hypervisor in hyperlight_host (instead of mshv2) #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marosset
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
syntactically,
jprendes and
simongdavies
as code owners
marosset
added
the
kind/dependencies
|
If you are doing this without removing the mshv2 code, and want to leave in the mshv2 CI checks for now, I think you need to change the cfg aliases here to make it so that having both mshv2 and mshv3 enabled results in mshv2 support instead of mshv3 support, or you need to build with no-default-features any time you want mshv2 support (which sounds a bit unpleasant). |
syntactically
previously approved these changes
Jul 15, 2025
marosset
force-pushed
the
mshv3-default
branch
4 times, most recently
from
4ecd737 to
664ffd9
Compare
…of mshv2) Signed-off-by: Mark Rossett <[email protected]>
ludfjig
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
mshv3as the default mshv hypervisor (instead ofmshv2) in preparation for deprecating/removing mshv2 support.