Make interrupt retry delay methods Linux-only #647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_interrupt_retry_delay
andset_interrupt_retry_delay
methods inSandboxConfiguration
were available on all platforms, but the retry delay value is only used on Linux and not read or written on Windows.Changes Made
Added
#[cfg(target_os = "linux")]
attributes to both methods:set_interrupt_retry_delay(&mut self, delay: Duration)
get_interrupt_retry_delay(&self) -> Duration
Rationale
LinuxInterruptHandle
in kvm.rs and hyperv_linux.rs) where retry delays are necessary due to timing windows when signals may not immediately interrupt the VCPU threadWHvCancelRunVirtualProcessor
(WindowsInterruptHandle
in hyperv_windows.rs) which doesn't require retry delaysThe struct field
interrupt_retry_delay
remains present on all platforms to maintain ABI compatibility, but the accessor methods are now properly scoped to Linux only.Testing
interrupt_custom_signal_no_and_retry_delay
continues to work correctlyFixes #592.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.