improve the performance of building page tables #635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the overhead of building page tables and page table entries, especially as the size of a sandboxes memory increases.
This pull request focuses on optimizing memory management in the
src/hyperlight_host/src/mem/mgr.rs
file, particularly improving the efficiency of page table entry (PTE) handling and memory region lookups. Key changes include pre-allocating buffers for PTEs, reducing shared memory writes, and introducing caching for sequential memory region access patterns.Memory Management Optimizations:
vec
to store all page table entries (pte_buffer
), minimizing shared memory writes by writing the entire buffer in one operation. [1] [2]copy_from_slice
. This approach avoids repeated conversions and individual writes, improving performance.Sequential Access Optimization:
get_page_flags
method to include a cached region index (cached_region_idx
) for faster sequential access. The method first checks the cached region, then adjacent regions, and falls back to binary search for non-sequential access patterns. [1] [2]