Improve the ergonomics of registering host functions #468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
register
andregister_with_extra_allowed_syscalls
methods to theUninitializedSandbox
to register host methods.e.g.,
This method accepts either:
FnMut(..) -> Result<R>
Arc<Mutex<FnMut(..) -> Result<R>>>
&Arc<Mutex<FnMut(..) -> Result<R>>>
This is controlled by the IntoHostFunction trait.
This is not a breaking change. It's an additive change, and the previous registration mechanism continues to works.