-
Notifications
You must be signed in to change notification settings - Fork 138
Open
Labels
lifecycle/confirmedBug is verified or proposal seems reasonableBug is verified or proposal seems reasonable
Milestone
Description
How do we ensure when someone upgrades to this new api that they don't assume that memory was already restored when it actually wasn't? Is that a concern?
Originally posted by @jsturtevant in #697 (comment)
In #697 we changed the behaviour of call_guest_function_by_name
, which can catch users by surprise. The linked issue proposes different alternatives to address this issue.
Some of the options proposed:
- Ensure we communicate this change clearly, using rustdocs and release notes
- Use the new behaviour in a
call
method, and replicate the old behaviour with the new API in thecall_guest_function_by_name
- Same as before, but with a deprecation warning on
call_guest_function_by_name
- Same as before, but with an unconditional error instead of a deprecation warning
Metadata
Metadata
Assignees
Labels
lifecycle/confirmedBug is verified or proposal seems reasonableBug is verified or proposal seems reasonable