-
Notifications
You must be signed in to change notification settings - Fork 138
Open
Labels
area/testingRelated to tests or testing infrastructureRelated to tests or testing infrastructurelifecycle/confirmedBug is verified or proposal seems reasonableBug is verified or proposal seems reasonable
Milestone
Description
LGTM.
Your comment about not seeing failures with clang.exe made me realise that I'm not sure if we actually have any tests in core hyperlight that make sure this toolchain works to build something; we used to use it to build WAMR when we were experimenting with that, but I don't think we have anything using it right now. It would be nice to add a test guest that actually builds libz or openssl or something with it, though. I don't know if it makes sense to that as part of this PR, but maybe add an issue for it if not?
Originally posted by @syntactically in #572 (review)
Metadata
Metadata
Assignees
Labels
area/testingRelated to tests or testing infrastructureRelated to tests or testing infrastructurelifecycle/confirmedBug is verified or proposal seems reasonableBug is verified or proposal seems reasonable
Type
Projects
Status
No status