Add per sandbox configuration for crashdumps #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Sturtevant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new method to the
SandboxBuilderclass for enabling or disabling crashdump generation in the sandbox. This functionality is gated behind thecrashdumpfeature flag.Key change:
src/hyperlight_wasm/src/sandbox/sandbox_builder.rs: Added thewith_crashdump_enabledmethod to allow toggling crashdump generation for the sandbox. This feature requires thecrashdumpfeature flag to be enabled.original PR in hyperlight: hyperlight-dev/hyperlight#417
The cargo lock was also not fully updated.