added arxiv retriever
#4538
Merged
added arxiv retriever
#4538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchase17
approved these changes
May 12, 2023
Contributor
hwchase17
left a comment
hwchase17
left a comment
There was a problem hiding this comment.
i actually really like this. looks great!
eyurtsev
reviewed
May 12, 2023
| from langchain.utilities.arxiv import ArxivAPIWrapper | ||
|
|
||
|
|
||
| class ArxivRetriever(BaseRetriever, ArxivAPIWrapper): |
Collaborator
There was a problem hiding this comment.
Would it make sense to change ArxivAPIWrapper into a DocumentLoader
and create a compositional pattern that allows upgrading a document loader into a retriever so we don't end up with double inheritance?
Collaborator
|
@leo-gan I REALLY like this PR and demo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
arxivretrieverWho can review?