Skip to content

Commit c67bea6

Browse files
huntiefacebook-github-bot
authored andcommitted
Hardcode Network Inspection flags to true
1 parent 7bbb13c commit c67bea6

File tree

5 files changed

+16
-18
lines changed

5 files changed

+16
-18
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<c7dc0406f2a4e8b4bedde09e8dec5b07>>
7+
* @generated SignedSource<<4a6cf1518f8f6ddf7dd57679d996ef41>>
88
*/
99

1010
/**
@@ -79,15 +79,15 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
7979

8080
override fun enableNativeCSSParsing(): Boolean = false
8181

82-
override fun enableNetworkEventReporting(): Boolean = false
82+
override fun enableNetworkEventReporting(): Boolean = true
8383

8484
override fun enableNewBackgroundAndBorderDrawables(): Boolean = true
8585

8686
override fun enablePreparedTextLayout(): Boolean = false
8787

8888
override fun enablePropsUpdateReconciliationAndroid(): Boolean = false
8989

90-
override fun enableResourceTimingAPI(): Boolean = false
90+
override fun enableResourceTimingAPI(): Boolean = true
9191

9292
override fun enableSynchronousStateUpdates(): Boolean = false
9393

@@ -109,7 +109,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
109109

110110
override fun fuseboxEnabledRelease(): Boolean = false
111111

112-
override fun fuseboxNetworkInspectionEnabled(): Boolean = false
112+
override fun fuseboxNetworkInspectionEnabled(): Boolean = true
113113

114114
override fun hideOffscreenVirtualViewsOnIOS(): Boolean = false
115115

packages/react-native/ReactCommon/jsinspector-modern/InspectorFlags.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@ const InspectorFlags::Values& InspectorFlags::loadFlagsAndAssertUnchanged()
5656
#else
5757
false,
5858
#endif
59-
.networkInspectionEnabled =
60-
ReactNativeFeatureFlags::enableBridgelessArchitecture() &&
61-
ReactNativeFeatureFlags::fuseboxNetworkInspectionEnabled(),
59+
.networkInspectionEnabled = true,
6260
};
6361

6462
if (cachedValues_.has_value() && !inconsistentFlagsStateLogged_) {

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<447ab7d26fc92000742788c2fba6e297>>
7+
* @generated SignedSource<<94a544a38e22fe3de5e2c1f5148bb54d>>
88
*/
99

1010
/**
@@ -140,7 +140,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
140140
}
141141

142142
bool enableNetworkEventReporting() override {
143-
return false;
143+
return true;
144144
}
145145

146146
bool enableNewBackgroundAndBorderDrawables() override {
@@ -156,7 +156,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
156156
}
157157

158158
bool enableResourceTimingAPI() override {
159-
return false;
159+
return true;
160160
}
161161

162162
bool enableSynchronousStateUpdates() override {
@@ -200,7 +200,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
200200
}
201201

202202
bool fuseboxNetworkInspectionEnabled() override {
203-
return false;
203+
return true;
204204
}
205205

206206
bool hideOffscreenVirtualViewsOnIOS() override {

packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ const definitions: FeatureFlagDefinitions = {
344344
ossReleaseStage: 'none',
345345
},
346346
enableNetworkEventReporting: {
347-
defaultValue: false,
347+
defaultValue: true,
348348
metadata: {
349349
description:
350350
'Enable network event reporting hooks in each native platform through `NetworkReporter`. This flag should be combined with `enableResourceTimingAPI` and `fuseboxNetworkInspectionEnabled` to enable end-to-end reporting behaviour via the Web Performance API and CDP debugging respectively.',
@@ -386,7 +386,7 @@ const definitions: FeatureFlagDefinitions = {
386386
ossReleaseStage: 'none',
387387
},
388388
enableResourceTimingAPI: {
389-
defaultValue: false,
389+
defaultValue: true,
390390
metadata: {
391391
description:
392392
'Enables the reporting of network resource timings through `PerformanceObserver`.',
@@ -502,7 +502,7 @@ const definitions: FeatureFlagDefinitions = {
502502
ossReleaseStage: 'none',
503503
},
504504
fuseboxNetworkInspectionEnabled: {
505-
defaultValue: false,
505+
defaultValue: true,
506506
metadata: {
507507
dateAdded: '2024-01-31',
508508
description:

packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<1c5a52b9ffce6f221ae263e90a79a8ab>>
7+
* @generated SignedSource<<eef10ab511b4b274d3db3903c814cbc7>>
88
* @flow strict
99
* @noformat
1010
*/
@@ -309,7 +309,7 @@ export const enableNativeCSSParsing: Getter<boolean> = createNativeFlagGetter('e
309309
/**
310310
* Enable network event reporting hooks in each native platform through `NetworkReporter`. This flag should be combined with `enableResourceTimingAPI` and `fuseboxNetworkInspectionEnabled` to enable end-to-end reporting behaviour via the Web Performance API and CDP debugging respectively.
311311
*/
312-
export const enableNetworkEventReporting: Getter<boolean> = createNativeFlagGetter('enableNetworkEventReporting', false);
312+
export const enableNetworkEventReporting: Getter<boolean> = createNativeFlagGetter('enableNetworkEventReporting', true);
313313
/**
314314
* Use BackgroundDrawable and BorderDrawable instead of CSSBackgroundDrawable
315315
*/
@@ -325,7 +325,7 @@ export const enablePropsUpdateReconciliationAndroid: Getter<boolean> = createNat
325325
/**
326326
* Enables the reporting of network resource timings through `PerformanceObserver`.
327327
*/
328-
export const enableResourceTimingAPI: Getter<boolean> = createNativeFlagGetter('enableResourceTimingAPI', false);
328+
export const enableResourceTimingAPI: Getter<boolean> = createNativeFlagGetter('enableResourceTimingAPI', true);
329329
/**
330330
* Dispatches state updates synchronously in Fabric (e.g.: updates the scroll position in the shadow tree synchronously from the main thread).
331331
*/
@@ -369,7 +369,7 @@ export const fuseboxEnabledRelease: Getter<boolean> = createNativeFlagGetter('fu
369369
/**
370370
* Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes.
371371
*/
372-
export const fuseboxNetworkInspectionEnabled: Getter<boolean> = createNativeFlagGetter('fuseboxNetworkInspectionEnabled', false);
372+
export const fuseboxNetworkInspectionEnabled: Getter<boolean> = createNativeFlagGetter('fuseboxNetworkInspectionEnabled', true);
373373
/**
374374
* Hides offscreen VirtualViews on iOS by setting hidden = YES to avoid extra cost of views
375375
*/

0 commit comments

Comments
 (0)