Skip to content

Conversation

@hrydgard
Copy link
Owner

Will fix problems with languages rendering as ????? caused by our font atlas not supporting that set of characters.

Helvetica doesn't quite feel right though... Gonna have to pick another of the shipped-with-the-OS fonts maybe.

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label May 25, 2024
@hrydgard hrydgard added this to the v1.18.0 milestone May 25, 2024
@hrydgard hrydgard marked this pull request as draft May 25, 2024 15:19
@hrydgard hrydgard force-pushed the native-text-draw-mac-ios branch 2 times, most recently from 282ab41 to 01b1190 Compare May 26, 2024 10:19
@hrydgard hrydgard force-pushed the native-text-draw-mac-ios branch from 01b1190 to c02e5b3 Compare May 29, 2024 17:30
@hrydgard hrydgard marked this pull request as ready for review May 29, 2024 17:30
@hrydgard
Copy link
Owner Author

hrydgard commented May 29, 2024

Haven't figured out how to load our TTF and make it prioritized, but the Apple default fonts look pretty good anyway, once I artificially boosted the font size a little.

Might later try to get the TTF loaded, but at least this fixes all problems with missing letters and so forth.

@hrydgard hrydgard changed the title Native text drawing on Mac/iOS Native text drawing on macOS/iOS May 29, 2024
@hrydgard hrydgard merged commit 1f7310d into master May 29, 2024
@hrydgard hrydgard deleted the native-text-draw-mac-ios branch May 29, 2024 17:52
Copy link

@Merucza-25 Merucza-25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2 pc 00000000008675f8 arm64/libppsspp_jni.so (HandleAssert(char const*, char const*, int, char const*, char const*, ...)+344) (BuildId: e2a665cce99374cec395cfef5394541ea8505f76)
#3 pc 00000000008398cc arm64/libppsspp_jni.so (VulkanRenderManager::BeginFrame(bool, bool)+280) (BuildId: e2a665cce99374cec395cfef5394541ea8505f76)
#4 pc 0000000000dd18b0 arm64/libppsspp_jni.so (Draw::VKContext::BeginFrame(Draw::DebugFlags)+32) (BuildId: e2a665cce99374cec395cfef5394541ea8505f76)
#5 pc 00000000008851b0 arm64/libppsspp_jni.so (NativeFrame(GraphicsContext*)+748) (BuildId: e2a665cce99374cec395cfef5394541ea8505f76)

@hrydgard
Copy link
Owner Author

@Merucza-25 That's an Android log, that's not what this issue is about. Post a new issue please if you have a reproducible crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants